From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id DB0A73858C20; Fri, 2 Jun 2023 18:26:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB0A73858C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685730362; bh=ybI0h9OhTEedvzxExeRj7vtfsafl1staPkCn1p8iNJ0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=hR3aE5y2X10G1jL0U1/G6OTHD0RVIAaJIYylXhCVWgMapvqS5kx4r6W4/x3sACiJO 5mivE5odRk75ta731+Ss0U32KwYgMIxClsPTprOoidZcvOdt9TQvz4x6Yho5VGoSxH 08ryEw7rnsb7EnpHJkBMdtv1KLvSCtZBsljWP0Rw= From: "mcermak at redhat dot com" To: systemtap@sourceware.org Subject: =?UTF-8?B?W0J1ZyBydW50aW1lLzMwNDE1XSBjb25mbGljdGluZyB0eXBlcyBm?= =?UTF-8?B?b3Ig4oCYa2FsbHN5bXNfb25fZWFjaF9zeW1ib2zigJk=?= Date: Fri, 02 Jun 2023 18:26:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mcermak at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30415 --- Comment #15 from Martin Cermak --- Created attachment 14913 --> https://sourceware.org/bugzilla/attachment.cgi?id=3D14913&action=3Ded= it possible patch (In reply to William Cohen from comment #14) > Is there a need for both stapkp_kernel_symbol_callback and > stapkp_module_symbol_callback? in kprobes.c? They look the same with > the exception of the function name. It would simplfy the code if > those were combined into a single function. Absolutely, I've combined them into one single stapkp_symbol_callback() > In runtime/linux/kprobe.c have: >=20 > extern void *_stp_module_kallsyms_on_each_symbol; >=20 > However, its static in runtime/linux/runtime.h: >=20 > static void *_stp_module_kallsyms_on_each_symbol; I've dropped the 'static' access control constraint in the header. --=20 You are receiving this mail because: You are the assignee for the bug.=