From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 69D1F3850400; Fri, 2 Jun 2023 15:22:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69D1F3850400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685719351; bh=AzcuKZCD2oxMdj7q4Bw1T2Cmfx4uCoqxdAj//cxNb98=; h=From:To:Subject:Date:In-Reply-To:References:From; b=s6zRNGUf9FBgzHtjsVXKveHp6yshz4nQQQJk0Kj4eXkwDDcQ3079xH69PVUeAW9WD g6oraUPiWti9lwtZ4ja0NC30KwQ/Qu/vCvJhk60FmEoCBfgXRDNJSNHzEmcYi0p7Qo vdXt8nOjKTfjPT8aSbl5IpiYmNJ6plNYNm5JsKUk= From: "wcohen at redhat dot com" To: systemtap@sourceware.org Subject: =?UTF-8?B?W0J1ZyBydW50aW1lLzMwNDE1XSBjb25mbGljdGluZyB0eXBlcyBm?= =?UTF-8?B?b3Ig4oCYa2FsbHN5bXNfb25fZWFjaF9zeW1ib2zigJk=?= Date: Fri, 02 Jun 2023 15:22:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: wcohen at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30415 --- Comment #14 from William Cohen --- Hi Martin, The patch is looking pretty good. There are just a few minor comments I ha= ve on it. One concern have is if RHEL backport some of the live patching support to RHEL kernel the kernel version checks might not catch that. However, probably better to just use the kernel version as currently done and fix the problem with autoconf check if/when RHEL backports patches. Is there a need for both stapkp_kernel_symbol_callback and stapkp_module_symbol_callback? in kprobes.c? They look the same with the exception of the function name. It would simplfy the code if those were combined into a single function. In runtime/linux/kprobe.c have: extern void *_stp_module_kallsyms_on_each_symbol; However, its static in runtime/linux/runtime.h: static void *_stp_module_kallsyms_on_each_symbol; --=20 You are receiving this mail because: You are the assignee for the bug.=