* [Bug runtime/30454] New: The stap runtime does not call nmi_uaccess_okay() to protect data races against CR3 switching on X86
@ 2023-05-16 21:02 agentzh at gmail dot com
2023-05-16 21:03 ` [Bug runtime/30454] " agentzh at gmail dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: agentzh at gmail dot com @ 2023-05-16 21:02 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=30454
Bug ID: 30454
Summary: The stap runtime does not call nmi_uaccess_okay() to
protect data races against CR3 switching on X86
Product: systemtap
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: runtime
Assignee: systemtap at sourceware dot org
Reporter: agentzh at gmail dot com
Target Milestone: ---
See the upstream kernel commit 4012e77a90 for more details.
I'm already preparing a fix.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug runtime/30454] The stap runtime does not call nmi_uaccess_okay() to protect data races against CR3 switching on X86
2023-05-16 21:02 [Bug runtime/30454] New: The stap runtime does not call nmi_uaccess_okay() to protect data races against CR3 switching on X86 agentzh at gmail dot com
@ 2023-05-16 21:03 ` agentzh at gmail dot com
2023-05-16 21:07 ` agentzh at gmail dot com
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: agentzh at gmail dot com @ 2023-05-16 21:03 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=30454
--- Comment #1 from agentzh <agentzh at gmail dot com> ---
This check should be done before trying to read userland memory.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug runtime/30454] The stap runtime does not call nmi_uaccess_okay() to protect data races against CR3 switching on X86
2023-05-16 21:02 [Bug runtime/30454] New: The stap runtime does not call nmi_uaccess_okay() to protect data races against CR3 switching on X86 agentzh at gmail dot com
2023-05-16 21:03 ` [Bug runtime/30454] " agentzh at gmail dot com
@ 2023-05-16 21:07 ` agentzh at gmail dot com
2023-05-16 21:31 ` agentzh at gmail dot com
2023-05-16 21:56 ` agentzh at gmail dot com
3 siblings, 0 replies; 5+ messages in thread
From: agentzh at gmail dot com @ 2023-05-16 21:07 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=30454
--- Comment #2 from agentzh <agentzh at gmail dot com> ---
And see also the upstream kernel commit d319f344561de.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug runtime/30454] The stap runtime does not call nmi_uaccess_okay() to protect data races against CR3 switching on X86
2023-05-16 21:02 [Bug runtime/30454] New: The stap runtime does not call nmi_uaccess_okay() to protect data races against CR3 switching on X86 agentzh at gmail dot com
2023-05-16 21:03 ` [Bug runtime/30454] " agentzh at gmail dot com
2023-05-16 21:07 ` agentzh at gmail dot com
@ 2023-05-16 21:31 ` agentzh at gmail dot com
2023-05-16 21:56 ` agentzh at gmail dot com
3 siblings, 0 replies; 5+ messages in thread
From: agentzh at gmail dot com @ 2023-05-16 21:31 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=30454
--- Comment #3 from agentzh <agentzh at gmail dot com> ---
I'd propose this patch for stap:
https://gist.github.com/agentzh/0ab23b34dea6afda43f1890ca2f2660b
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug runtime/30454] The stap runtime does not call nmi_uaccess_okay() to protect data races against CR3 switching on X86
2023-05-16 21:02 [Bug runtime/30454] New: The stap runtime does not call nmi_uaccess_okay() to protect data races against CR3 switching on X86 agentzh at gmail dot com
` (2 preceding siblings ...)
2023-05-16 21:31 ` agentzh at gmail dot com
@ 2023-05-16 21:56 ` agentzh at gmail dot com
3 siblings, 0 replies; 5+ messages in thread
From: agentzh at gmail dot com @ 2023-05-16 21:56 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=30454
agentzh <agentzh at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from agentzh <agentzh at gmail dot com> ---
Pushed the fix as commit c0430f888c73.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-16 21:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-16 21:02 [Bug runtime/30454] New: The stap runtime does not call nmi_uaccess_okay() to protect data races against CR3 switching on X86 agentzh at gmail dot com
2023-05-16 21:03 ` [Bug runtime/30454] " agentzh at gmail dot com
2023-05-16 21:07 ` agentzh at gmail dot com
2023-05-16 21:31 ` agentzh at gmail dot com
2023-05-16 21:56 ` agentzh at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).