[Bug runtime/30459] New: Ko compilation failures with kernel 6.1/6.2 kernel headers

[Bug runtime/30459] New: Ko compilation failures with kernel 6.1/6.2 kernel headers

[agentzh at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30459

            Bug ID: 30459
           Summary: Ko compilation failures with kernel 6.1/6.2 kernel
                    headers
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: agentzh at gmail dot com
  Target Milestone: ---

For some nontrivial stap scripts compiled with Fedora 36's 6.1 and 6.2 kernels,
the kernel build system trows out the following compilation errors:

```
In file included from
/opt/stap-plus/share/systemtap/runtime/linux/runtime.h:301,
                 from /opt/stap-plus/share/systemtap/runtime/runtime.h:26,
                 from
/tmp/stapzRqxL5/stap_61c4c192c40cf6ad899afb44bb419d45_1848_src.c:17:
/opt/stap-plus/share/systemtap/runtime/sym.c: In function
‘_stp_usermodule_check’:
/opt/stap-plus/share/systemtap/runtime/sym.c:983:1: error: the frame size of
2056 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
  983 | }
      | ^
cc1: all warnings being treated as errors
make[1]: *** [scripts/Makefile.build:250:
/tmp/stapzRqxL5/stap_61c4c192c40cf6ad899afb44bb419d45_1848_src.o] Error 1
make: *** [Makefile:2016: /tmp/stapzRqxL5] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed.  [man error::pass4]
```

An unused C array is allocated on the stack, which triggers this error. I'll
prepare a patch to fix this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/30459] Ko compilation failures with kernel 6.1/6.2 kernel headers

[agentzh at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30459

--- Comment #1 from agentzh <agentzh at gmail dot com> ---
I'd propose this patch to fix this issue:
https://gist.github.com/agentzh/b171be912307c1a63bd2c5374f3698ed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/30459] Ko compilation failures with kernel 6.1/6.2 kernel headers

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30459

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wcohen at redhat dot com

--- Comment #2 from William Cohen <wcohen at redhat dot com> ---
The proposed fix to remove the large unused array has been checked into
systemtap.  Can this PR be closed now?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/30459] Ko compilation failures with kernel 6.1/6.2 kernel headers

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30459

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from William Cohen <wcohen at redhat dot com> ---
This appears to addressed with the removal of the unused array in the
_stp_usermodule_check function.

-- 
You are receiving this mail because:
You are the assignee for the bug.