From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 20C7B3857738; Thu, 6 Jul 2023 16:05:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20C7B3857738 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688659545; bh=ysYph2Ek7WvX7EnufRFKc9USfr6UOR6e+gFvYiThvHw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Hb6GT8dqGjdPUx1PCD8aYPZ0Nz8DydmMmPr7U6l/DwhPMX0hw61TyCJCxSLmk5Taw Cc0SFLYyxdb9OGFcwfkZ/XwWdnr/uxIs8//eat6Xxy69pUArX2tM4lkQewp5gcs4e/ PjlIsZ0JbYOi8RuK4ARwv28aIYQFzs0OjMFCD3HE= From: "wcohen at redhat dot com" To: systemtap@sourceware.org Subject: [Bug runtime/30617] Systemtap unable to successfully build kernel modules for linux-6.5 Date: Thu, 06 Jul 2023 16:05:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: wcohen at redhat dot com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30617 William Cohen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from William Cohen --- Found that the specific upstream linux kernel git commit causing the issue = is: commit ca5e863233e8f6acd1792fd85d6bc2729a1b2c10 Author: Lorenzo Stoakes Date: Wed May 17 20:25:39 2023 +0100 mm/gup: remove vmas parameter from get_user_pages_remote() The only instances of get_user_pages_remote() invocations which used the vmas parameter were for a single page which can instead simply look up = the VMA directly. In particular:- - __update_ref_ctr() looked up the VMA but did nothing with it so we si= mply remove it. - __access_remote_vm() was already using vma_lookup() when the original lookup failed so by doing the lookup directly this also de-duplicates= the code. We are able to perform these VMA operations as we already hold the mmap_lock in order to be able to call get_user_pages_remote(). As part of this work we add get_user_page_vma_remote() which abstracts = the VMA lookup, error handling and decrementing the page reference count sh= ould the VMA lookup fail. This forms part of a broader set of patches intended to eliminate the v= mas parameter altogether. [akpm@linux-foundation.org: avoid passing NULL to PTR_ERR] Link: https://lkml.kernel.org/r/d20128c849ecdbf4dd01cc828fcec32127ed939a.16843508= 71.git.lstoakes@gmail.com Signed-off-by: Lorenzo Stoakes Reviewed-by: Catalin Marinas (for arm64) Acked-by: David Hildenbrand Reviewed-by: Janosch Frank (for s390) Reviewed-by: Christoph Hellwig Cc: Christian K=C3=B6nig Cc: Dennis Dalessandro Cc: Greg Kroah-Hartman Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Cc: Jens Axboe Cc: Matthew Wilcox (Oracle) Cc: Sakari Ailus Cc: Sean Christopherson Signed-off-by: Andrew Morton The vma argument is dropped from get_user_pages_remote() and a get_user_page_vma_remote() should be used in situations where vma being pas= sed into get_user_pages_remote() is non-NULL. The plan of action to fix this is to check for get_user_page_vma_remote() a= s a autoconf test and then use it in the systemtap runtime if it is available. --=20 You are receiving this mail because: You are the assignee for the bug.=