public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/30716] On x86_64 get objtool warnings:  call to __get_user_nocheck_1() with UACCESS enabled
Date: Wed, 25 Oct 2023 23:09:44 +0000	[thread overview]
Message-ID: <bug-30716-6586-s2nl2mDDMw@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30716-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30716

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #3 from William Cohen <wcohen at redhat dot com> ---
The x86_64 RHEL9 5.14.0 is a bit different than the newer 6.x kernels in
Fedora.  The CONFIG_HAVE_UACCESS_VALIDATION was added by kernel git commit
5f3da8c08508df828235 around april 2022 and doesn't exist in the older 5.14
RHEL9 kernel.  Thus, the current systemtap patch for this PR doesn't turn off
the objtool --uaccess analysis/warning in RHEL9.  I looked for alternative. 
The CONFIG_OBJTOOL was added to the kernel about the same time as the
CONFIG_HAVE_UACESS_VALIDATION, april 2022. For the 5.14 kernels the use of
--uaccess option for objtool is control by  CONFIG_X86_SMAP,
https://elixir.bootlin.com/linux/v5.14/source/arch/x86/Kconfig#L1806.  However,
it is likely that turning this off is going to cause problems for the Intel
processors that have actually have that feature enabled like the Intel IBT
support.

https://edc.intel.com/content/www/us/en/design/ipla/software-development-platforms/servers/platforms/intel-pentium-silver-and-intel-celeron-processors-datasheet-volume-1-of-2/005/intel-supervisor-mode-access-protection-smap/

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2023-10-25 23:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 15:28 [Bug runtime/30716] New: " wcohen at redhat dot com
2023-08-03 19:45 ` [Bug runtime/30716] " wcohen at redhat dot com
2023-08-23 13:09 ` fche at redhat dot com
2023-10-25 23:09 ` wcohen at redhat dot com [this message]
2024-03-05  0:33 ` wcohen at redhat dot com
2024-03-07 18:55 ` wcohen at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30716-6586-s2nl2mDDMw@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).