public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/30777] Systemtap modules unable to run on systemtap supporting Intel CET IBT
Date: Thu, 17 Aug 2023 15:48:11 +0000	[thread overview]
Message-ID: <bug-30777-6586-DTJzu0NADt@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30777-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30777

--- Comment #1 from William Cohen <wcohen at redhat dot com> ---
When comparing the output of objdump of the
/usr/lib/debug/lib/modules/6.4.10-200.fc38.x86_64/vmlinux and the dmesg "Code
:" it appears that the ENDBR64 and the 
call to __fentry__ get overwrite with a multibyte nop:

from the objdump -d /usr/lib/debug/lib/modules/6.4.10-200.fc38.x86_64/vmlinux

ffffffff81206980 <kallsyms_lookup_name>:
kallsyms_lookup_name():
/usr/src/debug/kernel-6.4.10/linux-6.4.10-200.fc38.x86_64/kernel/kallsyms.c:271
ffffffff81206980:       f3 0f 1e fa             endbr64
ffffffff81206984:       e8 27 dc e7 ff          call   ffffffff810845b0
<__fentry__>
ffffffff81206989:       53                      push   %rbx
ffffffff8120698a:       48 83 ec 10             sub    $0x10,%rsp

From the dmesg output:

Code: 79 0a 48 f7 d0 48 03 05 d6 41 5b 01 c3 cc cc cc cc 66 0f 1f 84 00 00 00
00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 <66> 0f 1f 00 0f 1f 44 00
00 53 48 83 ec 10 65 48 8b 04 25 28 00 00

Working through to match up objdump and dmesg output:

<66> 0f 1f 00 0f 1f 44 00 00  nopw   0x0(%rax,%rax,1)  # *doesn't match
original code*
53                            push   %rbx  
48 83 ec 10                   sub    %0x10,$rsp
65 48 8b 04 25 28 00          mov    %gs:0x28,%rax

Something has changed the entry for kallsyms_lookup_name.  Internal kernel
calls to the function still work because those are not using indirect calls
(call *%reg).

-- 
You are receiving this mail because:
You are the assignee for the bug.

  reply	other threads:[~2023-08-17 15:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 15:37 [Bug runtime/30777] New: " wcohen at redhat dot com
2023-08-17 15:48 ` wcohen at redhat dot com [this message]
2023-08-22 15:26 ` [Bug runtime/30777] " wcohen at redhat dot com
2023-08-24 19:10 ` wcohen at redhat dot com
2023-08-27 23:40 ` wcohen at redhat dot com
2023-08-29 14:09 ` wcohen at redhat dot com
2023-08-29 15:53 ` wcohen at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30777-6586-DTJzu0NADt@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).