From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id B0FE33858410; Thu, 7 Sep 2023 19:23:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0FE33858410 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694114620; bh=booa4nu56HUBu1BMnqyAXnC2yd1mEoSwu2pdXDwzzZI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=fa/SxwNjkGCxM5wcd0QZx6L/xurlWFbnpOtX1L5UWKfd+J9EaVNEi2KQ5I0tszFCD biXp0YwA3o96XBPrpJqx732yZ/3aG3E8KYQjEj9zNVomIqxGV7E0moepzZzM3dgKao 8662ozE8WbKz6cVCdw5eINc6a0GPdDG2PeF4eC90= From: "wcohen at redhat dot com" To: systemtap@sourceware.org Subject: [Bug runtime/30831] Systemtap scripts fail to compile on newest linux 6.6 kernels Date: Thu, 07 Sep 2023 19:23:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: wcohen at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: short_desc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30831 William Cohen changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The do_each_thread macro |Systemtap scripts fail to |has been removed from |compile on newest linux |newest linux 6.6 kernels |6.6 kernels --- Comment #1 from William Cohen --- With minor tweaks in the runtime to use the for_each_process_thread macro. = Get a new set of errors when the generated C code is compiled: $ sudo ../install/bin/stap -e 'probe begin {printf("hi!\n");exit()}' In file included from /home/wcohen/systemtap_write/install/share/systemtap/runtime/runtime.h:26, from /tmp/stapGSFULg/stap_9dfacd1f722045d5e3bceb982809b15d_1345_src.c:21: /home/wcohen/systemtap_write/install/share/systemtap/runtime/stp_task_work.= c: In function =E2=80=98stp_task_work_add=E2=80=99: /home/wcohen/systemtap_write/install/share/systemtap/runtime/stp_task_work.= c:9:102: error: implicit conversion from =E2=80=98enum =E2=80=99 to =E2= =80=98enum task_work_notify_mode=E2=80=99 [-Werror=3Denum-conversion] 9 | apper(int, (* (task_work_add_fn)kallsyms_task_work_add)((a), (b), (= c))) | ^= ~~ /home/wcohen/systemtap_write/install/share/systemtap/runtime/linux/runtime.= h:298:21: note: in definition of macro =E2=80=98ibt_wrapper=E2=80=99 298 | rettype retval =3D (function); \ | ^~~~~~~~ /home/wcohen/systemtap_write/install/share/systemtap/runtime/stp_task_work.= c:92:14: note: in expansion of macro =E2=80=98task_work_add=E2=80=99 92 | rc =3D task_work_add(task, twork, true); | ^~~~~~~~~~~~~ In file included from ./include/linux/srcu.h:21, from ./include/linux/notifier.h:16, from ./arch/x86/include/asm/uprobes.h:13, from ./include/linux/uprobes.h:49, from ./include/linux/mm_types.h:16, from ./include/linux/mmzone.h:22, from ./include/linux/gfp.h:7, from /home/wcohen/systemtap_write/install/share/systemtap/runtime/linux/runtime_= defines.h:20, from /home/wcohen/systemtap_write/install/share/systemtap/runtime/runtime_define= s.h:8, from /tmp/stapGSFULg/stap_9dfacd1f722045d5e3bceb982809b15d_1345_src.c:12: In function =E2=80=98stp_synchronize_sched=E2=80=99, inlined from =E2=80=98_stp_cleanup_and_exit.part.0=E2=80=99 at /home/wcohen/systemtap_write/install/share/systemtap/runtime/transport/tran= sport.c:412:25: ./include/linux/workqueue.h:631:9: error: call to =E2=80=98__warn_flushing_systemwide_wq=E2=80=99 declared with attribute war= ning: Please avoid flushing system-wide workqueues. [-Werror=3Dattribute-warning] 631 | __warn_flushing_systemwide_wq();=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/wcohen/systemtap_write/install/share/systemtap/runtime/linux/runtime.= h:407:3: note: in expansion of macro =E2=80=98flush_scheduled_work=E2=80=99 407 | flush_scheduled_work(); | ^~~~~~~~~~~~~~~~~~~~ In function =E2=80=98stp_synchronize_sched=E2=80=99, inlined from =E2=80=98systemtap_module_exit=E2=80=99 at /tmp/stapGSFULg/stap_9dfacd1f722045d5e3bceb982809b15d_1345_src.c:472:3, inlined from =E2=80=98_stp_cleanup_and_exit.part.0=E2=80=99 at /home/wcohen/systemtap_write/install/share/systemtap/runtime/transport/tran= sport.c:420:4: ./include/linux/workqueue.h:631:9: error: call to =E2=80=98__warn_flushing_systemwide_wq=E2=80=99 declared with attribute war= ning: Please avoid flushing system-wide workqueues. [-Werror=3Dattribute-warning] 631 | __warn_flushing_systemwide_wq();=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/wcohen/systemtap_write/install/share/systemtap/runtime/linux/runtime.= h:407:3: note: in expansion of macro =E2=80=98flush_scheduled_work=E2=80=99 407 | flush_scheduled_work(); | ^~~~~~~~~~~~~~~~~~~~ In function =E2=80=98stp_synchronize_sched=E2=80=99, inlined from =E2=80=98systemtap_module_exit=E2=80=99 at /tmp/stapGSFULg/stap_9dfacd1f722045d5e3bceb982809b15d_1345_src.c:485:3, inlined from =E2=80=98_stp_cleanup_and_exit.part.0=E2=80=99 at /home/wcohen/systemtap_write/install/share/systemtap/runtime/transport/tran= sport.c:420:4: ./include/linux/workqueue.h:631:9: error: call to =E2=80=98__warn_flushing_systemwide_wq=E2=80=99 declared with attribute war= ning: Please avoid flushing system-wide workqueues. [-Werror=3Dattribute-warning] 631 | __warn_flushing_systemwide_wq();=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/wcohen/systemtap_write/install/share/systemtap/runtime/linux/runtime.= h:407:3: note: in expansion of macro =E2=80=98flush_scheduled_work=E2=80=99 407 | flush_scheduled_work(); | ^~~~~~~~~~~~~~~~~~~~ In function =E2=80=98stp_synchronize_sched=E2=80=99, inlined from =E2=80=98systemtap_module_exit=E2=80=99 at /tmp/stapGSFULg/stap_9dfacd1f722045d5e3bceb982809b15d_1345_src.c:488:3, inlined from =E2=80=98_stp_cleanup_and_exit.part.0=E2=80=99 at /home/wcohen/systemtap_write/install/share/systemtap/runtime/transport/tran= sport.c:420:4: ./include/linux/workqueue.h:631:9: error: call to =E2=80=98__warn_flushing_systemwide_wq=E2=80=99 declared with attribute war= ning: Please avoid flushing system-wide workqueues. [-Werror=3Dattribute-warning] 631 | __warn_flushing_systemwide_wq();=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/wcohen/systemtap_write/install/share/systemtap/runtime/linux/runtime.= h:407:3: note: in expansion of macro =E2=80=98flush_scheduled_work=E2=80=99 407 | flush_scheduled_work(); | ^~~~~~~~~~~~~~~~~~~~ In function =E2=80=98stp_synchronize_sched=E2=80=99, inlined from =E2=80=98systemtap_module_init=E2=80=99 at /tmp/stapGSFULg/stap_9dfacd1f722045d5e3bceb982809b15d_1345_src.c:420:3, inlined from =E2=80=98_stp_handle_start=E2=80=99 at /home/wcohen/systemtap_write/install/share/systemtap/runtime/transport/tran= sport.c:264:13, inlined from =E2=80=98_stp_ctl_write_cmd=E2=80=99 at /home/wcohen/systemtap_write/install/share/systemtap/runtime/transport/cont= rol.c:82:17: ./include/linux/workqueue.h:631:9: error: call to =E2=80=98__warn_flushing_systemwide_wq=E2=80=99 declared with attribute war= ning: Please avoid flushing system-wide workqueues. [-Werror=3Dattribute-warning] 631 | __warn_flushing_systemwide_wq();=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/wcohen/systemtap_write/install/share/systemtap/runtime/linux/runtime.= h:407:3: note: in expansion of macro =E2=80=98flush_scheduled_work=E2=80=99 407 | flush_scheduled_work(); | ^~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [scripts/Makefile.build:243: /tmp/stapGSFULg/stap_9dfacd1f722045d5e3bceb982809b15d_1345_src.o] Error 1 make: *** [Makefile:1931: /tmp/stapGSFULg] Error 2 WARNING: kbuild exited with status: 2 Pass 4: compilation failed. [man error::pass4] --=20 You are receiving this mail because: You are the assignee for the bug.=