From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id AE4363858D20; Fri, 20 Oct 2023 14:42:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE4363858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1697812965; bh=qwPY/LKT5dFkvCWgIBq3QmISmO66hrC0Ud4O6odpEg4=; h=From:To:Subject:Date:From; b=FCaBDfbiljzVYLrL97HhoMWAn6xT/MCRxtlgD5Q/8YD/z4kuUL4N4M9rrT8Euaj1b zdQB57Q2OKCTj5KCyrwL4nGUZNp87ZqTn57w6e4YoyTxEHBcYorKKhyKNYBrCTUDad FFzi+gketdfR58qKQBzT8vF7SwPtrfiuOidekUJ8= From: "wcohen at redhat dot com" To: systemtap@sourceware.org Subject: [Bug runtime/30987] New: Addition of strlcopy and strlcat to glibc prevents compilation of dyninst based systemtap instrumentation Date: Fri, 20 Oct 2023 14:42:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: wcohen at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30987 Bug ID: 30987 Summary: Addition of strlcopy and strlcat to glibc prevents compilation of dyninst based systemtap instrumentation Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: runtime Assignee: systemtap at sourceware dot org Reporter: wcohen at redhat dot com Target Milestone: --- On Fedora rawhide the systemtap "make installcheck" tests building instrumentation using dyninst fail to compile because glibc has added strlc= py and strlcat to the /usr/include/string.h file and those declarations confli= ct with the static inlined functioned in runtime/dynsint/linux_defs.h. This is causing over 400 failures on rawhide for the "make installcheck". Can replicate with: sudo make installcheck RUNTESTFLAGS=3D"systemtap.base/ret-uprobe-var.exp" And see following in the output: FAIL: ret-uprobe-var: TEST 1: @var in return probes should not be stale (4.= 1+) (dyninst): stderr: string should be "", but got "In file included from /home/wcohen/systemtap_write/install/share/systemtap/runtime/dyninst/runtim= e.h:92, from /home/wcohen/systemtap_write/install/share/systemtap/runtime/runtime.h:30, from /tmp/stapDni8D1/stap_e18df6414ee02f320dd0e235e95dc3d9_2203_src.c:21: /home/wcohen/systemtap_write/install/share/systemtap/runtime/dyninst/linux_= defs.h:100:22: error: static declaration of 'strlcpy' follows non-static declaration 100 | static inline size_t strlcpy(char *__restrict dest, const char *__restrict src, size_t size) | ^~~~~~~ In file included from /home/wcohen/systemtap_write/install/share/systemtap/runtime/dyninst/runtim= e.h:22: /usr/include/string.h:506:15: note: previous declaration of 'strlcpy' with = type 'size_t(char * restrict, const char * restrict, size_t)' {aka 'long unsig= ned int(char * restrict, const char * restrict, long unsigned int)'} 506 | extern size_t strlcpy (char *__restrict __dest, | ^~~~~~~ /home/wcohen/systemtap_write/install/share/systemtap/runtime/dyninst/linux_= defs.h:112:22: error: static declaration of 'strlcat' follows non-static declaration 112 | static inline size_t strlcat(char *__restrict dest, const char *__restrict src, size_t count) | ^~~~~~~ /usr/include/string.h:512:15: note: previous declaration of 'strlcat' with = type 'size_t(char * restrict, const char * restrict, size_t)' {aka 'long unsig= ned int(char * restrict, const char * restrict, long unsigned int)'} 512 | extern size_t strlcat (char *__restrict __dest, | ^~~~~~~ WARNING: gcc exited with status: 1 Pass 4: compilation failed. [man error::pass4] " --=20 You are receiving this mail because: You are the assignee for the bug.=