From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 90923385840B; Tue, 24 Oct 2023 18:20:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 90923385840B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1698171620; bh=P7LkHD42MldqolAM45gtqZUKQts9KaJmYsBiFWBCGF4=; h=From:To:Subject:Date:From; b=g/+PFF0AuN+l1DPZ6kOXg+nQVXhtQBUL8ZUoG0p+i0M4Vmzf23RJaWdr4FmQXx86J l/8kTJGPUQ9DuYqDWG+Qphor4KwQhuIZm5X4+PH19hAlZQVT901eG3PunxnFMhbz7P CaD7ArMDSkou3RuNymf/BeBIE0YKRm4809Q60znc= From: "wcohen at redhat dot com" To: systemtap@sourceware.org Subject: [Bug runtime/30999] New: _kretprobe_data needs to be adjusted to support changes in the kernel's struct kretprobe_instance Date: Tue, 24 Oct 2023 18:20:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: wcohen at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30999 Bug ID: 30999 Summary: _kretprobe_data needs to be adjusted to support changes in the kernel's struct kretprobe_instance Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: runtime Assignee: systemtap at sourceware dot org Reporter: wcohen at redhat dot com Target Milestone: --- On RHEL9 and various Fedora machine have systemtap.base/kretprobe-vars.stp = fail to build because of kernel git commit d741bf41d7c7db4898bacfcb020353cddc032= fd8: kprobes: Remove kretprobe hash The kretprobe hash is mostly superfluous, replace it with a per-task variable. This gets rid of the task hash and it's related locking. Note that this may change the kprobes module-exported API for kretprobe handlers. If any out-of-tree kretprobe user uses ri->rp, use get_kretprobe(ri) instead. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Masami Hiramatsu Signed-off-by: Ingo Molnar Link: https://lore.kernel.org/r/159870620431.1229682.16325792502413731312.stgit@d= evnote2 When the test attempts to run will see the following in systemtap.log: Running /root/systemtap_write/systemtap/testsuite/systemtap.base/kretprobe-vars.exp= ... executing: stap -v -c {cat /dev/null} -w /root/systemtap_write/systemtap/testsuite/systemtap.base/kretprobe-vars.stp spawn stap -v -c cat /dev/null -w /root/systemtap_write/systemtap/testsuite/systemtap.base/kretprobe-vars.stp= ^M Pass 1: parsed user script and 466 library scripts using 119104virt/89268res/13444shr/75648data kb, in 130usr/30sys/17\ 2real ms.^M Pass 2: analyzed script: 5 probes, 15 functions, 1 embed, 7 globals using 187148virt/158660res/14612shr/143692data kb,\ in 1270usr/110sys/1368real ms.^M Pass 3: translated to C into "/tmp/stap9WEX7h/stap_b1f325e4c83bee966f3421ee4b0c9033_8031_src.c" using 187148virt/16052\ 4res/16468shr/143692data kb, in 0usr/80sys/96real ms.^M /tmp/stap9WEX7h/stap_b1f325e4c83bee966f3421ee4b0c9033_8031_src.c: In functi= on '_kretprobe_data':^M /tmp/stap9WEX7h/stap_b1f325e4c83bee966f3421ee4b0c9033_8031_src.c:31:46: err= or: 'struct kretprobe_instance' has no memb\ er named 'rp'; did you mean 'rph'?^M 31 | if (end > offset && pi && end <=3D pi->rp->data_size)^M | ^~^M | rph^M /tmp/stap9WEX7h/stap_b1f325e4c83bee966f3421ee4b0c9033_8031_src.c: At top level:^M cc1: note: unrecognized command-line option '-Wno-infinite-recursion' may h= ave been intended to silence earlier diagno\ stics^M make[4]: *** [scripts/Makefile.build:299: /tmp/stap9WEX7h/stap_b1f325e4c83bee966f3421ee4b0c9033_8031_src.o] Error 1^M make[3]: *** [Makefile:1928: /tmp/stap9WEX7h] Error 2^M WARNING: kbuild exited with status: 2^M Pass 4: compiled C into "stap_b1f325e4c83bee966f3421ee4b0c9033_8031.ko" in 1120usr/210sys/1028real ms.^M Pass 4: compilation failed. [man error::pass4]^M Kernel version 5.14.0 is within tested range 2.6.32 ... 6.5^M FAIL: kretprobe-vars startup (eof) --=20 You are receiving this mail because: You are the assignee for the bug.=