From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 84B01386F424; Fri, 5 Jan 2024 14:50:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84B01386F424 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1704466252; bh=U0tWWxv3fmtBcK67d3vS47XnyEyDcxY35lb3sKMat1U=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ADnSvZfdhz5I2T+ASMQyChLWGJmjDdMpEUOYkNfKR4yvofsryKdBdkIaLh9j2AgcI EeZuSmb7Svm21K+kddhNS2FfmzPicCIePr07XWsfSoKFfsmfP9ZJNWcp4BRzQpAb/j 4o7EfHAykhUadlV6Enttozp6V2CflFs4xPywzLaE= From: "mcermak at redhat dot com" To: systemtap@sourceware.org Subject: [Bug runtime/31117] transport failures Date: Fri, 05 Jan 2024 14:50:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mcermak at redhat dot com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31117 --- Comment #6 from Martin Cermak --- Created attachment 15287 --> https://sourceware.org/bugzilla/attachment.cgi?id=3D15287&action=3Ded= it possible patch for the 32-bit tests subproblem (In reply to William Cohen from comment #5) > The attached patch improves the test results for the systemtap.map tests > that were transporting more than PAGE_SIZE amount of data. It also impro= ves > the test results for the syscall tests. Thank-you for looking into this Will! > However, on RHEL9/f39 there > are a number of unrelated failures on x86_64 for the 32-bit tests because > the check for the syscall names/numbers added by git commit > 7fe1b7bb8e665c9edd38eaf34a499618ee763293 Looking closer... Apparently on RHEL9 the @__compat_task macro <=3D _stp_is_compat_task() <=3D _stp_is_compat_task2() in runtime/compatdefs.h doesn't work right. Wow, I think I have a fix for that see attached. Here= is how my thoughts went: I've tested the problem is in _stp_is_compat_task2(), that's in runtime/compatdefs.h. I've found that a related systemtap commit is ea81249b90b92a589d304c051efbc5bbad7ce073. This mentions kernel commit ff170cd05953, so I've looked at that, and found that kernel function is_64bit_mm() seems to be doing what I need. I've then looked at the modern implementation of this function, and used that back in systemtap's _stp_is_compat_task2(). And that seems to work on my specific test system, which is 5.14.0-402.el9.x86_64. The attached patch works for me on both RHEL8 and RHEL9. BUT ... this seem= s to be a case where this upstream kernel change introduced in vanilla v6.3 was backported to lower distribution kernel version, so the condition "#if LINUX_VERSION_CODE < KERNEL_VERSION(5,0,0)" is a bit problematic.. --=20 You are receiving this mail because: You are the assignee for the bug.=