From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 4138B385841E; Mon,  4 Mar 2024 21:31:00 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4138B385841E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1709587860;
	bh=85dF4rb5ABOaiNWn8u5Z/+bbXWIA0lr5rQuW2wsM5Zs=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Y7Z52Fk92hFxsdACQrCQsYNqrEUllEFhZGzh1JLJlfy5WNa6s8TaEXg9oVtvhZ2O1
	 YR/Zgq6SsDw/XOtZStK9an0wm/MLjFBzL3kJMOWjXzpmgFm/WfKAqucPwZu01xipZ2
	 dhchSC6psNgSHKyHkJJWJpkvp2/Pyf2olYePDBs8=
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/31117] transport failures
Date: Mon, 04 Mar 2024 21:30:59 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: runtime
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: wcohen at redhat dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: resolution bug_status
Message-ID: <bug-31117-6586-hmK0ZyiK2w@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-31117-6586@http.sourceware.org/bugzilla/>
References: <bug-31117-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <systemtap.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31117

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #17 from William Cohen <wcohen at redhat dot com> ---
This PR should be addressed by:

commit d1b74b12acc07f52c7d8f5b080176c485c34cd63 (HEAD -> master, origin/mas=
ter,
origin/HEAD)
Author: William Cohen <wcohen@redhat.com>
Date:   Mon Mar 4 16:27:18 2024 -0500

    PR31117: Correct handling of transport layer allocated memory

    The _stp_print_flush() code was not correct.  There are four possible
    ranges of values compared to the header size (hlen)
    _stp_data_write_reserve() could return when beginning to write out
    log:

    <0      unable to allocate any space
    <hlen   pad out the allocated space and try another allocation
    =3D=3Dhlen  just enough space for the initial header
    >hlen   write out the header and some portion of log

    The case where the space allocated was equal size of the header
    (=3D=3Dhlen) was not handled correctly.  In the cases where there was o=
nly
    enough room to write the header the _stp_transport_failures variable
    was incremented and none of the log data was written out.  The correct
    course of action in these cases would be to write the header out in
    the allocated space and start looping to write the rest of the log
    data.

--=20
You are receiving this mail because:
You are the assignee for the bug.=