public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/31404] Systemtap unable to find kernel.trace("*") probe points on Fedora rawhide Linux 6.8 kernels
Date: Wed, 28 Feb 2024 14:49:28 +0000	[thread overview]
Message-ID: <bug-31404-6586-q4WDUZq3fB@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31404-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31404

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from William Cohen <wcohen at redhat dot com> ---
Was able to compare the tracequery_kmod_1 builds between fedora 39 and rawhide.
 The problem on rawhide is that the additional -Werror-missing-prototypes
option is being passed into rawhide build which causes:

$  ../install/bin/stap  --disable-cache -k -vvvvv -L
'kernel.trace("sys_enter")' >& rawhide_log
have /tmp/stapypAUhu
make -C /lib/modules/$(uname -r)/build M=/tmp/stapypAUhu/tracequery_kmod_1
modules
 make -C /lib/modules/$(uname -r)/build M=/tmp/stapypAUhu/tracequery_kmod_1
modules
make: Entering directory
'/usr/src/kernels/6.8.0-0.rc5.20240222git39133352cbed.44.fc41.x86_64'
  CC [M]  /tmp/stapypAUhu/tracequery_kmod_1/tracequery_kmod_1_2.o
/tmp/stapypAUhu/tracequery_kmod_1/tracequery_kmod_1_2.c:51:8: error: no
previous prototype for ‘stapprobe_read_msr’ [-Werror=missing-prototypes]
   51 |   void stapprobe_##name(proto) {}
      |        ^~~~~~~~~~
./include/linux/tracepoint.h:555:9: note: in expansion of macro ‘DECLARE_TRACE’
  555 |         DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
      |         ^~~~~~~~~~~~~
./arch/x86/include/asm/msr-trace.h:40:1: note: in expansion of macro
‘DEFINE_EVENT’
   40 | DEFINE_EVENT(msr_trace_class, read_msr,
      | ^~~~~~~~~~~~
/tmp/stapypAUhu/tracequery_kmod_1/tracequery_kmod_1_2.c:51:8: error: no
previous prototype for ‘stapprobe_write_msr’ [-Werror=missing-prototypes]
   51 |   void stapprobe_##name(proto) {}
      |        ^~~~~~~~~~
./include/linux/tracepoint.h:555:9: note: in expansion of macro ‘DECLARE_TRACE’
  555 |         DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
      |         ^~~~~~~~~~~~~
./arch/x86/include/asm/msr-trace.h:45:1: note: in expansion of macro
‘DEFINE_EVENT’
   45 | DEFINE_EVENT(msr_trace_class, write_msr,
      | ^~~~~~~~~~~~
/tmp/stapypAUhu/tracequery_kmod_1/tracequery_kmod_1_2.c:51:8: error: no
previous prototype for ‘stapprobe_rdpmc’ [-Werror=missing-prototypes]
   51 |   void stapprobe_##name(proto) {}
      |        ^~~~~~~~~~
./include/linux/tracepoint.h:555:9: note: in expansion of macro ‘DECLARE_TRACE’
  555 |         DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
      |         ^~~~~~~~~~~~~
./arch/x86/include/asm/msr-trace.h:50:1: note: in expansion of macro
‘DEFINE_EVENT’
   50 | DEFINE_EVENT(msr_trace_class, rdpmc,
      | ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [scripts/Makefile.build:243:
/tmp/stapypAUhu/tracequery_kmod_1/tracequery_kmod_1_2.o] Error 1
make[1]: ***
[/usr/src/kernels/6.8.0-0.rc5.20240222git39133352cbed.44.fc41.x86_64/Makefile:1939:
/tmp/stapypAUhu/tracequery_kmod_1] Error 2
make: *** [Makefile:252: __sub-make] Error 2
make: Leaving directory
'/usr/src/kernels/6.8.0-0.rc5.20240222git39133352cbed.44.fc41.x86_64'

There looks to be a couple ways to fix this.

1) kernel git commit 1c57b9f63ab34f01b8c73731cc0efacb5a9a2f16 adds a "static"
before the function definition.

2) kernel git commit c97dac57c804b53eab492ca0230d86356729d633 adds following
line to Kbuild to remove the -Wmissing-prototypes:

+KBUILD_CFLAGS := $(filter-out -Wmissing-prototypes -Wmissing-declarations,
$(KBUILD_CFLAGS))
+

-- 
You are receiving this mail because:
You are the assignee for the bug.

  reply	other threads:[~2024-02-28 14:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 14:47 [Bug translator/31404] New: " wcohen at redhat dot com
2024-02-28 14:49 ` wcohen at redhat dot com [this message]
2024-02-28 15:52 ` [Bug translator/31404] " wcohen at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31404-6586-q4WDUZq3fB@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).