public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/31500] stapio exited with irqs disabled
Date: Wed, 20 Mar 2024 21:10:54 +0000	[thread overview]
Message-ID: <bug-31500-6586-KMvxLqW6Ek@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31500-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31500

--- Comment #7 from William Cohen <wcohen at redhat dot com> ---
I did some more looking around to see where the session's guru_mode would
affect the list of points blocked.  The following URL points at a line that
mentions PR6503, work to allow probing function in the init/exit sections of a
module.  If the probe is on kernel code the init/exit sections are blocked:

https://sourceware.org/git/?p=systemtap.git;a=blob;f=dwflpp.cxx;h=26e9144cdcc7083581aeff3e101044b5542f43d8;hb=HEAD#l4519

However, the test for guru_mode ignores that and sets the blocklisted to 
dwflpp::blocklisted_none allowing problematic probe in kernels init to be
probed:

https://sourceware.org/git/?p=systemtap.git;a=blob;f=dwflpp.cxx;h=26e9144cdcc7083581aeff3e101044b5542f43d8;hb=HEAD#l4543

Maybe the following line:

if (sess.guru_mode)

should be:

if (sess.guru_mode && module != TOK_KERNEL)

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2024-03-20 21:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-16 13:03 [Bug runtime/31500] New: " mcermak at redhat dot com
2024-03-18 21:48 ` [Bug runtime/31500] " wcohen at redhat dot com
2024-03-19  8:10 ` mcermak at redhat dot com
2024-03-19 15:49 ` wcohen at redhat dot com
2024-03-19 20:57 ` wcohen at redhat dot com
2024-03-20 14:19 ` wcohen at redhat dot com
2024-03-20 15:25 ` wcohen at redhat dot com
2024-03-20 21:10 ` wcohen at redhat dot com [this message]
2024-03-21 14:31 ` wcohen at redhat dot com
2024-03-21 15:13 ` wcohen at redhat dot com
2024-03-22 14:40 ` wcohen at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31500-6586-KMvxLqW6Ek@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).