From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id EC3073858CD1; Tue,  2 Apr 2024 19:13:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC3073858CD1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1712085210;
	bh=18NcKPOg5ZyUfJ8LKajaVfw8/mucLAAh+R/6iDODXS0=;
	h=From:To:Subject:Date:From;
	b=k/Vgfpg6+s+IXr6ZX++S3clKOF3+RZMhTJ51GhZuxn1WcB4Ijj0M/pAAsmrobSI0M
	 ly65ZR1aQhHksa3iPJe9jhMbM4mIdjlcLmNAUCzBqOFUdzNKPVKH+6u+adv5TWUKWP
	 sZ0hbmXFBFJS6dqKC6cST7aDi3x6MLRh50Es8WYM=
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/31597] New: Systemtap not extracting all the data sent
 to the print data in the buffers before shutdown
Date: Tue, 02 Apr 2024 19:13:29 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: runtime
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: wcohen at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-31597-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <systemtap.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31597

            Bug ID: 31597
           Summary: Systemtap not extracting all the data sent to the
                    print data in the buffers before shutdown
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: wcohen at redhat dot com
  Target Milestone: ---

When reviewing the tests results for the syscall.exp tests different runs of
the same tests would have different tests fail.  The syscall.exp tests shou=
ld
be deterministics, but they are not. Note even those the second and third r=
un
have same number of passes there are difference in which specific tests pas=
sed.
Four different runs of:

sudo make installcheck RUNTESTFLAGS=3Dsyscall.exp


                =3D=3D=3D systemtap Summary =3D=3D=3D

# of expected passes            302
# of unexpected failures        38
# of untested testcases         1
# of unsupported tests          4

                =3D=3D=3D systemtap Summary =3D=3D=3D

# of expected passes            299
# of unexpected failures        41
# of untested testcases         1
# of unsupported tests          4

                =3D=3D=3D systemtap Summary =3D=3D=3D

# of expected passes            299
# of unexpected failures        41
# of untested testcases         1
# of unsupported tests          4

                =3D=3D=3D systemtap Summary =3D=3D=3D

# of expected passes            295
# of unexpected failures        45
# of untested testcases         1
# of unsupported tests          4

One of the things that this test does is use the -c option to shut down the
systemtap instrumentation when the user-space command completes.  However, =
it
appears that the shutdown sometimes happens too quickly and some of the pri=
nt
output saved in the buffer has not been read out of the buffers, causing the
output to be truncated and the test to fail.  To test this hypothesis I put
"sleep(1);" before the "stop_threads =3D 1;" in close_relayfs() and
kill_relayfs() functions in staprun/relay.c.  I compared the systemtap.sum
output for the delayed shutdown.  The only changes were the additional PASS=
 in
the version with the failure. There were no FAIL: in the delayed version wh=
ere
the previous 4 runs has PASS:.

--=20
You are receiving this mail because:
You are the assignee for the bug.=