From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70771 invoked by alias); 1 Jul 2016 17:47:09 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 70759 invoked by uid 89); 1 Jul 2016 17:47:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HX-Envelope-From:sk:jistone, H*F:U*jistone, hunks, Feel X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 01 Jul 2016 17:46:55 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F26F7552FE; Fri, 1 Jul 2016 17:46:53 +0000 (UTC) Received: from [10.3.116.77] (ovpn-116-77.phx2.redhat.com [10.3.116.77]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u61Hkr8e021978; Fri, 1 Jul 2016 13:46:53 -0400 Subject: Re: SystemTap for Android - patchset To: Alexander Lochmann , systemtap@sourceware.org References: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> From: Josh Stone Message-ID: Date: Fri, 01 Jul 2016 17:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-q3/txt/msg00004.txt.bz2 On 07/01/2016 09:15 AM, Alexander Lochmann wrote: > > Hi folks! > > Finally, I decided to submit my patch, which makes SystemTap work for > Android. Moreover, it adds two new features: > - Support for ignoring all available tapset directories, except the one > that is provided by -K Can you explain why you need this? One can already override the primary tapset directory with the environment SYSTEMTAP_TAPSET. Ignoring -I options also seems questionable, especially since this depends on the order -- it looks like -I specified after -K will still be used, while those before will be ignored. > - Support for a pid file in staprun, parameter is -U And you added -M on stap itself. I don't understand either of those letter choices. The functionality itself is not too controversial, but I'd still like to see your justification in the commit log, and some examples how this is used in Android. > I had to modify several source files of staprun. Those changes are > mostly copied from the corresponding files contained in commit > 2c10863bfe41b51272eff714a837f4977bdc257a. For some reasons, those ifdef > parts have been removed. I readded them, and changed the macro, which > activates them. That commit is "man stap: fixed typos". Did you mean something else? > The patch contains two bugfixes for the SystemTap as well. > Unfortunately, I failed to extract those fixes properly. :( As David said, it would help us a lot if you separated each of these changes into distinct commits. If you have the changes in a working git directory, "git add -p" can help you mark specific changes to be committed. "git-gui" is also pretty good for selecting hunks. Feel free to ask for help on #systemtap if you still have trouble. > The first fix starts at line 510, and goes until line 555. > Since an older kernel like 3.0 does not support uprobes, systemtap > includes 'runtime/linux/task_finder_stubs.c'. That file itself does > *not* include 'syscall.h', which declares several syscall-related functions. > The second fix starts at line 1106. For some reasons in the Linux kernel > 3.0 the macro cputime_to_usecs() has a semicolon at the end of its > definition. Therefore, the defition of cputime_to_msecs() in ' > tapset/linux/task_time.stp' must be modified to deal with that fact. > > Cheers, > Alex > > --- > Technische Universität Dortmund > Alexander Lochmann PGP key: 0xBC3EF6FD > Otto-Hahn-Str. 16 phone: +49.231.7556141 > D-44227 Dortmund fax: +49.231.7556116 > http://ess.cs.tu-dortmund.de/Staff/al >