From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1715 invoked by alias); 19 May 2009 01:07:18 -0000 Received: (qmail 1702 invoked by uid 22791); 19 May 2009 01:07:17 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from an-out-0708.google.com (HELO an-out-0708.google.com) (209.85.132.250) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 May 2009 01:07:13 +0000 Received: by an-out-0708.google.com with SMTP id c2so2545118anc.35 for ; Mon, 18 May 2009 18:07:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.141.15 with SMTP id o15mr10005197and.20.1242695231206; Mon, 18 May 2009 18:07:11 -0700 (PDT) Date: Tue, 19 May 2009 01:07:00 -0000 Message-ID: Subject: [Patch 1/2] Enhance -s option checking to only accept valid size number From: Sunzen Wang To: systemtap@sources.redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00620.txt.bz2 Fix: Enhance -s option checking to only accept valid size number --- diff --git a/main.cxx b/main.cxx index 39d835d..ec5506f 100644 --- a/main.cxx +++ b/main.cxx @@ -626,8 +626,8 @@ main (int argc, char * const argv []) break; case 's': - s.buffer_size = atoi (optarg); - if (s.buffer_size < 1 || s.buffer_size > 4095) + s.buffer_size = (int) strtoul (optarg, &num_endptr, 10); + if (*num_endptr != '\0' || s.buffer_size < 1 || s.buffer_size > 4095) { cerr << "Invalid buffer size (should be 1-4095)." << endl; usage (s, 1); --- -- sunzen <>