From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78866 invoked by alias); 26 Dec 2018 09:53:27 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 78748 invoked by uid 89); 26 Dec 2018 09:53:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.6 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=SCL, scl, wei, H*UA:Intel X-HELO: mail-io1-f66.google.com Received: from mail-io1-f66.google.com (HELO mail-io1-f66.google.com) (209.85.166.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Dec 2018 09:53:24 +0000 Received: by mail-io1-f66.google.com with SMTP id p7so1103915iog.12 for ; Wed, 26 Dec 2018 01:53:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=H/7YYtv2NR7jBAiEBuaRXkEWyff7t0mR6RlFsZZWrps=; b=VsQFcMTHSJSwfUBsIlXGRjs6fJCIyVXlyz1xz7GaXhUKsGrm6yptjuqvB4FomxD7m4 RD9+/mdml9LvYJb5o3A6lVSoxOnIn5gM1TucgWcE3EmRS0sHnJGpHnd9ci/Ga1BKE3ZH q1Vd0HMnzCpEI56NLjhR7qXkKKN1Foqr7V85JOP1msCcDnxzHskHhxFezAiIF6uMYgYF 2z9QGyVPFdxojzsjqmkTUK3xU16D22mlUoA5oojd8f80SnH5uiES8s6QbUdV2HcNpsnh WMS4q/4xqWJXKcO9X+oy4YV1euJmJyB9U5Yudifac6u+PNIAJU9a4G/4LrVcs5QL/Dzd G5uA== Return-Path: Received: from yangdeMacBook-Pro.local ([23.248.163.20]) by smtp.gmail.com with ESMTPSA id 189sm12621676itw.33.2018.12.26.01.53.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Dec 2018 01:53:22 -0800 (PST) Subject: Re: [PATCH] buildrun: no sanitize $PATH for kbuild invocation To: "faicker.mo" , systemtap@sourceware.org References: <1545379729-30048-1-git-send-email-faicker.mo@ucloud.cn> From: wyang Message-ID: Date: Wed, 26 Dec 2018 09:53:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1545379729-30048-1-git-send-email-faicker.mo@ucloud.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-q4/txt/msg00136.txt.bz2 Please try to use -B, you can pass option to kbuild. Wei On 2018/12/21 下午4:08, faicker.mo wrote: > From: "faicker.mo" > > For newer kernel, SCL with newer gcc and systemtap prepends > it's directory to the $PATH to take effect. It doesn't work > if $PATH is sanitized (prefixed with /usr/bin:/bin:) > > Fixes e8474d2a > > Signed-off-by: faicker.mo > --- > buildrun.cxx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/buildrun.cxx b/buildrun.cxx > index cef14ad..dcdb6e8 100644 > --- a/buildrun.cxx > +++ b/buildrun.cxx > @@ -99,7 +99,7 @@ make_any_make_cmd(systemtap_session& s, const string& dir, const string& target) > const char *oldpath = getenv("PATH"); > if (oldpath != NULL) > { > - newpath += ':'; > + newpath = "PATH="; > newpath += oldpath; > } >