From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98825 invoked by alias); 8 Feb 2019 20:37:03 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 98813 invoked by uid 89); 8 Feb 2019 20:37:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=monitored, william, William, 2333 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Feb 2019 20:37:01 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D186883F42 for ; Fri, 8 Feb 2019 20:36:59 +0000 (UTC) Received: from [10.13.129.79] (dhcp129-79.rdu.redhat.com [10.13.129.79]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0A2145AE for ; Fri, 8 Feb 2019 20:36:59 +0000 (UTC) Subject: Re: Review of the systemtap examples testsuite results x86 Fedora rawhide From: William Cohen To: systemtap@sourceware.org References: Message-ID: Date: Fri, 08 Feb 2019 20:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-q1/txt/msg00038.txt.bz2 On 2/6/19 4:41 PM, William Cohen wrote: > Now that systemtap is working with 5.0.0-rcx kernel took the time to run the > systemtap examples to see what failed. > > The following two tests are failing because "vitural memory exhausted" > Both are using --all-modules. There are some other test other PASS: > but it looks like they result in smaller stap-symbols.h files. These > particular tests look to be because stap-symbols.h files are huge, > over 70MB. This fail might be more of a result of the guest VM having > 2GB of RAM. However, not sure why there is such variations in the > in the size of the stap-symbols.h files > > FAIL: systemtap.examples/profiling/fileline-profile run > FAIL: systemtap.examples/profiling/periodic build When running the fileline-profile see cc1 get way up there in memory use on successful run on a machine with ample resources: PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 17936 root 20 0 3013476 2.4g 12484 R 100.0 7.6 0:23.33 cc1 similarly for periodic.stp see: PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 21631 root 20 0 3656892 2.7g 21588 R 99.7 8.8 0:29.40 cc1 > >> Kernel commit 23c9deeb328 eliminates all the FAN_ALL_* defines causing > FAN_ALL_CLASS_BITS to be undefined. This commit is also in the 4.20 > kernels, so the errsnoop and strace examples will also break on Fedora > 29/28. _fanotify_init_flags_str function in > tapset/linux/aux_syscalls.stp will need to be fixed up. > > FAIL: systemtap.examples/process/errsnoop build > FAIL: systemtap.examples/process/strace build Both errsnoop and strace are working now with systemtap git commits: 4e76869512d2d05fc3347861bdeed92395e34d63 1ac5a4499ecc17f612a94bf4dff39ba90d4cd532 However, noticed that there appears to be some nd_syscall.*.retrun probes missing retstr given the following warnings when running strace.stp: WARNING: never-assigned local variable 'retstr' (similar: argstr, status, name, _target_set, thread_argstr): identifier 'retstr' at strace.stp:49:38 source: report(name,thread_argstr[tid()],retstr) ^ WARNING: never-assigned local variable 'retstr' (similar: argstr, status, name, _target_set, thread_argstr): identifier 'retstr' at :49:38 source: report(name,thread_argstr[tid()],retstr) ^ WARNING: never-assigned local variable 'retstr' (similar: argstr, status, name, _target_set, thread_argstr): identifier 'retstr' at :49:38 source: report(name,thread_argstr[tid()],retstr) ^ WARNING: never-assigned local variable 'retstr' (similar: argstr, status, name, _target_set, thread_argstr): identifier 'retstr' at :49:38 source: report(name,thread_argstr[tid()],retstr) > > > The following two tests seem to be having issues with the > kernel.statement() on do_sys_open being used for them. Both get > "inconsistent relocation address". > > FAIL: systemtap.examples/general/varwatch build > FAIL: systemtap.examples/general/whythefail build > > > The following test appears not to go down some other function other > than the vfs_* functions being currently monitored. This does work on > RHEL7. Looking through the list of EXPORT_SYMBOLS(vfs_*) in > linux/fs/namei.c it looks like vfs_tmpfile or vfs_mkobj are likely > missing probes: > > FAIL: systemtap.examples/general/badname run Found that badname.stp last worked in linux 4.6 and was broken in 4.7. Did a kernel bisect today and found that the following kernel commit caused this example to stop working: commit 6ac087099edf09ca357e2f765e3e24677543897c Author: Al Viro Date: Tue Apr 26 00:02:50 2016 -0400 path_openat(): take O_PATH handling out of do_last() do_last() and lookup_open() simpler that way and so does O_PATH itself. As it bloody well should: we find what the pathname resolves to, same way as in stat() et.al. and associate it with FMODE_PATH struct file. Signed-off-by: Al Viro > > > The syscall.ptrace probe point is now using the nodwarf version, so > $request target variable isn't available > > FAIL: systemtap.examples/process/noptrace build > > > Lots of kernel internal ABI changes making the following fail to build: > > FAIL: systemtap.examples/process/pfiles build > > -Will >