From: fche@redhat.com (Frank Ch. Eigler)
To: Andre Detsch <adetsch@br.ibm.com>
Cc: systemtap@sources.redhat.com
Subject: Re: [PATCH] Update SCSI tapset
Date: Fri, 18 Dec 2009 17:19:00 -0000 [thread overview]
Message-ID: <y0m1vis9p4y.fsf@fche.csb> (raw)
In-Reply-To: <200912022012.53460.adetsch@br.ibm.com> (Andre Detsch's message of "Wed, 2 Dec 2009 20:12:53 -0200")
Andre Detsch <adetsch@br.ibm.com> writes:
> This patch updates the scsi.stp tapset, as long as the correspondent testcase.
> [...]
> Changes are:
> * Inclusion of two new probes: scsi.set_state and scsi.ioexecute
> * device_state and data_direction values are now available in string
> form, reflecting the enum identificator, instead of its integer id
> * Minor fix in scsi.iodispatching documentation: "req_bufflen" is actually
> called "request_bufflen"
> * Testcase now prints not only the values, but also the name of the fields
> * Some housekeeping, such as white space and tabulation fixes
> [...]
Looks good to me. Is the existing scsi-related example (iostat-scsi)
a sufficient showcase of this tapset?
- FChE
next prev parent reply other threads:[~2009-12-18 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 22:13 Andre Detsch
2009-12-18 17:19 ` Frank Ch. Eigler [this message]
2009-12-23 18:57 ` Andre Detsch
2009-12-23 20:56 ` Frank Ch. Eigler
2009-12-22 18:13 ` K.Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y0m1vis9p4y.fsf@fche.csb \
--to=fche@redhat.com \
--cc=adetsch@br.ibm.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).