From: fche@redhat.com (Frank Ch. Eigler)
To: Josh Stone <jistone@redhat.com>
Cc: Mark Wielaard <mjw@redhat.com>,
systemtap@sourceware.org, dsmith@redhat.com
Subject: Re: Fixed PR13146 by not allowing memory allocations to sleep
Date: Tue, 25 Oct 2011 12:07:00 -0000 [thread overview]
Message-ID: <y0m39ehwa02.fsf@fche.csb> (raw)
In-Reply-To: <4E82481E.8060502@redhat.com> (Josh Stone's message of "Tue, 27 Sep 2011 15:03:10 -0700")
jistone wrote:
> [...]
> I agree, those contexts which can sleep, should. Not only does this
> make it more likely we'll get the memory we want, but also makes us
> better citizens with the rest of the kernel.
Unfortunately, that's not quite sound policy either. The memory
allocation aggressiveness pendulum has swung too far with the new
code, and now large data structures are allocated with plain
GFP_KERNEL. On small-memory machines, this is found to OOM the
system, rather than let the stap module give up early.
An intermediate approach is needed; maybe __GFP_REPEAT & !__GFP_NOWAIT.
- FChE
next prev parent reply other threads:[~2011-10-25 12:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110901143940.13672.qmail@sourceware.org>
2011-09-27 14:52 ` Fixed PR13146 by not allowing memory allocations to sleep (Was: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-1.6-151-g8e794e9) Mark Wielaard
2011-09-27 22:03 ` Josh Stone
2011-09-27 23:01 ` Jim Keniston
2011-09-28 12:12 ` Mark Wielaard
2011-10-05 13:44 ` David Smith
2011-10-05 13:47 ` David Smith
2011-10-05 15:24 ` Jim Keniston
2011-10-05 16:00 ` Ananth N Mavinakayanahalli
2011-10-25 12:07 ` Frank Ch. Eigler [this message]
2011-10-25 12:19 ` Fixed PR13146 by not allowing memory allocations to sleep Mark Wielaard
2011-10-31 10:26 ` Mark Wielaard
2011-10-31 15:19 ` Frank Ch. Eigler
2011-10-31 15:30 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y0m39ehwa02.fsf@fche.csb \
--to=fche@redhat.com \
--cc=dsmith@redhat.com \
--cc=jistone@redhat.com \
--cc=mjw@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).