From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 677 invoked by alias); 9 Nov 2009 17:02:14 -0000 Received: (qmail 649 invoked by uid 22791); 9 Nov 2009 17:02:14 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 17:02:08 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA9H25aV007951 for ; Mon, 9 Nov 2009 12:02:05 -0500 Received: from fche.csb (vpn-227-196.phx2.redhat.com [10.3.227.196]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA9H25u7032192; Mon, 9 Nov 2009 12:02:05 -0500 Received: by fche.csb (Postfix, from userid 2569) id C41DF58101; Mon, 9 Nov 2009 12:02:04 -0500 (EST) To: Rajasekhar Duddu Cc: systemtap@sources.redhat.com Subject: Re: [PATCH V3] Tracepoint Tapset for Memory Subsystem References: <20091109071004.GA8837@rajduddu> From: fche@redhat.com (Frank Ch. Eigler) Date: Mon, 09 Nov 2009 17:02:00 -0000 In-Reply-To: <20091109071004.GA8837@rajduddu> (Rajasekhar Duddu's message of "Mon, 9 Nov 2009 12:40:04 +0530") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00471.txt.bz2 Rajasekhar Duddu writes: > Hi all, > here I am sending the updated patch based on all the > previous comments. Please review it and let me know if it needs any > more improvemnts. [...] I didn't see anything objectionable in a quick scan. I would like to see a demo script (systemtap.examples/*) that somehow goes beyond just tracing individual calls (like the buildok test). - FChE