From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-1607-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 1831 invoked by alias); 8 Nov 2005 17:02:29 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
Received: (qmail 1752 invoked by uid 22791); 8 Nov 2005 17:02:24 -0000
X-Authentication-Warning: toenail.toronto.redhat.com: fche set sender to fche@redhat.com using -f
To: "Mao, Bibo" <bibo.mao@intel.com>
Cc: <systemtap@sources.redhat.com>
Subject: Re: new systemtap snapshot available
References: <9FBCE015AF479F46B3B410499F3AE05B08979C@pdsmsx405>
From: fche@redhat.com (Frank Ch. Eigler)
Date: Tue, 08 Nov 2005 17:02:00 -0000
In-Reply-To: <9FBCE015AF479F46B3B410499F3AE05B08979C@pdsmsx405>
Message-ID: <y0m4q6nxecm.fsf@toenail.toronto.redhat.com>
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.4
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2005-q4/txt/msg00167.txt.bz2

"Mao, Bibo" <bibo.mao@intel.com> writes:

> [...]
> 	/tmp/stapsOq5Wi/stap_19359.c: In function `function_accumulate':
> 	/tmp/stapsOq5Wi/stap_19359.c:382: warning: cast from pointer to integer =
> [...]
> So I modify translate.cxx,as follows: [...]
> And it will compile and run ok in my IA32, EM64T and IA64 box.

Thank you for your patch, now committed.  I'm also adding the following
blurb to the HACKING guidelines:

   As far as practicable, changes should be accompanied by test cases
-  to prevent future regressions.
+  to prevent future regressions.  Tests should be run on at least
+  x86, and ideally also on some 64-bit platform.

- FChE