From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27828 invoked by alias); 20 Dec 2014 12:58:53 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 27819 invoked by uid 89); 20 Dec 2014 12:58:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 20 Dec 2014 12:58:51 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBKCwnSQ003878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sat, 20 Dec 2014 07:58:49 -0500 Received: from fche.csb (vpn-60-95.rdu2.redhat.com [10.10.60.95]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBKCwnSG003926; Sat, 20 Dec 2014 07:58:49 -0500 Received: by fche.csb (Postfix, from userid 2569) id E1F9958194; Sat, 20 Dec 2014 07:58:38 -0500 (EST) To: Abe Jakop Cc: systemtap@sourceware.org Subject: Re: Systemtap Upcoming Feature: Address to File:Line Mapping References: <252539308.11641276.1418658500370.JavaMail.zimbra@redhat.com> <2066955740.484444.1418939520703.JavaMail.zimbra@redhat.com> <997469081.1170736.1419031176504.JavaMail.zimbra@redhat.com> From: fche@redhat.com (Frank Ch. Eigler) Date: Sat, 20 Dec 2014 12:58:00 -0000 In-Reply-To: <997469081.1170736.1419031176504.JavaMail.zimbra@redhat.com> (Abe Jakop's message of "Fri, 19 Dec 2014 18:19:36 -0500 (EST)") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2014-q4/txt/msg00242.txt.bz2 ajakop wrote: > [...] >> Glancing at that pf3.stp sample, maybe [u]sym* family of functions >> should more regularly throw catchable errors in case of errors, >> instead of hard-coding a policy of returning a hexified parameter. [...] > > Would this not cause backwards compatibility issues? Or were you thinking > this change would be effective for SystemTap versions >=2.7? Yes & yes - akin to what we did earlier in PR15044. > Should I open a PR for this change and another for the feature below? Yes, please! - FChE PS. Yes.