From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15985 invoked by alias); 16 Sep 2014 14:41:00 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 15968 invoked by uid 89); 16 Sep 2014 14:40:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 16 Sep 2014 14:40:58 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8GEetCD002548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 16 Sep 2014 10:40:55 -0400 Received: from fche.csb (vpn-228-210.phx2.redhat.com [10.3.228.210]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8GEetua014734; Tue, 16 Sep 2014 10:40:55 -0400 Received: by fche.csb (Postfix, from userid 2569) id B5E935853A; Tue, 16 Sep 2014 10:40:54 -0400 (EDT) To: Santosh Shukla Cc: dsmith@redhat.com, jistone@redhat.com, systemtap@sourceware.org Subject: Re: [SYSTEMTAP/PATCH v2 0/6] RT aware systemtap patch set References: <1410871795-12539-1-git-send-email-sshukla@mvista.com> From: fche@redhat.com (Frank Ch. Eigler) Date: Tue, 16 Sep 2014 14:41:00 -0000 In-Reply-To: <1410871795-12539-1-git-send-email-sshukla@mvista.com> (Santosh Shukla's message of "Tue, 16 Sep 2014 18:19:49 +0530") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2014-q3/txt/msg00275.txt.bz2 Santosh Shukla writes: > [...] This is a v2 version of -rt aware systemtap patchset, tested > for 3.14.12-rt9 and for 3.10.40-rt38 kernel version. [...] Thanks! > [...] > Test script used for testing : > /usr/local/stap/bin/stap -v testsuite/systemtap.examples/network/netdev.stp > /usr/local/stap/bin/stap -v testsuite/systemtap.examples/network/tcpdumplike.stp > [...] > Like know feedback, comment on patch set. also Does it make sense to maintain > systemtap -rt version in upstream.. do we care? Thanks to Josh for looking into this in more detail. I only have the general observation that this patchset would be desirable in mainline stap, but only if it is tested by at least the whole testsuite (rather than just those two samples) on your -rt kernel, *and* if the patched code also runs the whole testsuite on a non-rt kernel. (We don't expect 100% PASS, but also no smoke attributable to the patches.) - FChE