From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29884 invoked by alias); 28 Sep 2008 13:38:20 -0000 Received: (qmail 29877 invoked by uid 22791); 28 Sep 2008 13:38:19 -0000 X-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 28 Sep 2008 13:37:44 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m8SDbgxg001256; Sun, 28 Sep 2008 09:37:42 -0400 Received: from pobox-3.corp.redhat.com (pobox-3.corp.redhat.com [10.11.255.67]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m8SDbgCI019098; Sun, 28 Sep 2008 09:37:42 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.yyz.redhat.com [10.15.16.9]) by pobox-3.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m8SDbH70029774; Sun, 28 Sep 2008 09:37:42 -0400 Received: from ton.toronto.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by touchme.toronto.redhat.com (Postfix) with ESMTP id F224A8001FF; Sun, 28 Sep 2008 09:37:00 -0400 (EDT) Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id m8SDaiqZ028966; Sun, 28 Sep 2008 09:36:44 -0400 Received: (from fche@localhost) by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id m8SDaiGW028965; Sun, 28 Sep 2008 09:36:44 -0400 X-Authentication-Warning: ton.toronto.redhat.com: fche set sender to fche@redhat.com using -f To: wenji.huang@oracle.com Cc: SystemTAP Subject: Re: [PATCH 3/3] PR4886: Check build-id in module_init function if able. References: <48DEEA31.9010004@oracle.com> From: fche@redhat.com (Frank Ch. Eigler) Date: Sun, 28 Sep 2008 13:38:00 -0000 In-Reply-To: <48DEEA31.9010004@oracle.com> (Wenji Huang's message of "Sun, 28 Sep 2008 10:21:37 +0800") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q3/txt/msg00803.txt.bz2 Hi, Wenji - Excellent work. If it passes regression tests, please check it in. It shouldn't be hard to apply it to userspace too, if it doesn't already just work. Some tweaks to the various messages may be helpful later, such as to print parts of the buildid strings for eyeballing by the user, but otherwise it looks just fine. - FChE