Latest systemtap fails when used with latest Linux kernel

Latest systemtap fails when used with latest Linux kernel

[Theodore Ts'o]

Using the latest Systemtap (commit be21f2db) compiling a 2.6.28-git7
kernel, I get this failure....

						- Ted

% stap --vp 0001 --vp 0001 helloworld.stp 
Running make -C "/lib/modules/2.6.28-05784-gd5b9778/build" M="/tmp/stapsXvMb1" modules >/dev/null
In file included from /usr/local/share/systemtap/runtime/transport/transport.c:23,
                 from /usr/local/share/systemtap/runtime/print.c:17,
                 from /usr/local/share/systemtap/runtime/runtime.h:84,
                 from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:41:
/usr/local/share/systemtap/runtime/transport/../procfs.c: In function ‘_stp_mkdir_proc_module’:
/usr/local/share/systemtap/runtime/transport/../procfs.c:102: error: ‘struct nameidata’ has no member named ‘dentry’
/usr/local/share/systemtap/runtime/transport/../procfs.c:103: error: implicit declaration of function ‘path_release’
In file included from /usr/local/share/systemtap/runtime/transport/transport.c:35,
                 from /usr/local/share/systemtap/runtime/print.c:17,
                 from /usr/local/share/systemtap/runtime/runtime.h:84,
                 from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:41:
/usr/local/share/systemtap/runtime/transport/utt.c: In function ‘utt_dropped_open’:
/usr/local/share/systemtap/runtime/transport/utt.c:199: error: ‘struct inode’ has no member named ‘u’
In file included from /usr/local/share/systemtap/runtime/print.c:17,
                 from /usr/local/share/systemtap/runtime/runtime.h:84,
                 from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:41:
/usr/local/share/systemtap/runtime/transport/transport.c: In function ‘_stp_transport_init’:
/usr/local/share/systemtap/runtime/transport/transport.c:214: error: ‘struct task_struct’ has no member named ‘uid’
/usr/local/share/systemtap/runtime/transport/transport.c:215: error: ‘struct task_struct’ has no member named ‘gid’
In file included from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:42:
/usr/local/share/systemtap/runtime/regs.c: In function ‘_stp_ret_addr’:
/usr/local/share/systemtap/runtime/regs.c:49: error: ‘struct pt_regs’ has no member named ‘esp’
/usr/local/share/systemtap/runtime/regs.c: In function ‘_stp_print_regs’:
/usr/local/share/systemtap/runtime/regs.c:235: error: ‘struct pt_regs’ has no member named ‘eip’
/usr/local/share/systemtap/runtime/regs.c:236: error: ‘struct pt_regs’ has no member named ‘esp’
/usr/local/share/systemtap/runtime/regs.c:238: error: ‘struct pt_regs’ has no member named ‘eax’
/usr/local/share/systemtap/runtime/regs.c:238: error: ‘struct pt_regs’ has no member named ‘ebx’
/usr/local/share/systemtap/runtime/regs.c:238: error: ‘struct pt_regs’ has no member named ‘ecx’
/usr/local/share/systemtap/runtime/regs.c:238: error: ‘struct pt_regs’ has no member named ‘edx’
/usr/local/share/systemtap/runtime/regs.c:240: error: ‘struct pt_regs’ has no member named ‘esi’
/usr/local/share/systemtap/runtime/regs.c:240: error: ‘struct pt_regs’ has no member named ‘edi’
/usr/local/share/systemtap/runtime/regs.c:240: error: ‘struct pt_regs’ has no member named ‘ebp’
/usr/local/share/systemtap/runtime/regs.c:242: error: ‘struct pt_regs’ has no member named ‘xds’
/usr/local/share/systemtap/runtime/regs.c:242: error: ‘struct pt_regs’ has no member named ‘xes’
/usr/local/share/systemtap/runtime/regs.c: In function ‘_stp_get_sp’:
/usr/local/share/systemtap/runtime/regs.c:417: error: ‘struct pt_regs’ has no member named ‘esp’
/usr/local/share/systemtap/runtime/regs.c:418: error: ‘struct pt_regs’ has no member named ‘esp’
/usr/local/share/systemtap/runtime/regs.c: In function ‘_stp_get_arg32_by_number’:
/usr/local/share/systemtap/runtime/regs.c:505: error: ‘struct pt_regs’ has no member named ‘eax’
/usr/local/share/systemtap/runtime/regs.c:506: error: ‘struct pt_regs’ has no member named ‘edx’
/usr/local/share/systemtap/runtime/regs.c:507: error: ‘struct pt_regs’ has no member named ‘ecx’
In file included from /usr/local/share/systemtap/runtime/stack.c:35,
                 from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:43:
/usr/local/share/systemtap/runtime/stack-i386.c: In function ‘__stp_stack_print’:
/usr/local/share/systemtap/runtime/stack-i386.c:33: error: ‘struct pt_regs’ has no member named ‘esp’
/usr/local/share/systemtap/runtime/stack-i386.c:37: error: ‘struct pt_regs’ has no member named ‘ebp’
In file included from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:43:
/usr/local/share/systemtap/runtime/stack.c: In function ‘_stp_stack_print’:
/usr/local/share/systemtap/runtime/stack.c:61: error: ‘struct pt_regs’ has no member named ‘eip’
/usr/local/share/systemtap/runtime/stack.c:65: error: ‘struct pt_regs’ has no member named ‘eip’
/usr/local/share/systemtap/runtime/stack.c:67: error: ‘struct pt_regs’ has no member named ‘eip’
distcc[11858] ERROR: compile /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c on localhost failed
make[1]: *** [/tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.o] Error 1
make: *** [_module_/tmp/stapsXvMb1] Error 2
Pass 4: compiled C into "stap_7e482897f22605cdad02e8e11f34d749_334.ko" in 860usr/790sys/1733real ms.
Pass 4: compilation failed.  Try again with another '--vp 0001' option.
Running rm -rf /tmp/stapsXvMb1

Re: Latest systemtap fails when used with latest Linux kernel

[Srikar Dronamraju]

Hi Ted, 

This error is occuring because of uid,gid,  fields in task_struct being
moved over to struct cred patch. Kamalesh has already raised a bug
http://sourceware.org/bugzilla/show_bug.cgi?id=9699 for the same. 

--
Thanks and Regards
Srikar

> 
> Using the latest Systemtap (commit be21f2db) compiling a 2.6.28-git7
> kernel, I get this failure....
> 
> 						- Ted
> 
> % stap --vp 0001 --vp 0001 helloworld.stp 
> Running make -C "/lib/modules/2.6.28-05784-gd5b9778/build" M="/tmp/stapsXvMb1" modules >/dev/null
> In file included from /usr/local/share/systemtap/runtime/transport/transport.c:23,
>                  from /usr/local/share/systemtap/runtime/print.c:17,
>                  from /usr/local/share/systemtap/runtime/runtime.h:84,
>                  from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:41:
> /usr/local/share/systemtap/runtime/transport/../procfs.c: In function ‘_stp_mkdir_proc_module’:
> /usr/local/share/systemtap/runtime/transport/../procfs.c:102: error: ‘struct nameidata’ has no member named ‘dentry’
> /usr/local/share/systemtap/runtime/transport/../procfs.c:103: error: implicit declaration of function ‘path_release’
> In file included from /usr/local/share/systemtap/runtime/transport/transport.c:35,
>                  from /usr/local/share/systemtap/runtime/print.c:17,
>                  from /usr/local/share/systemtap/runtime/runtime.h:84,
>                  from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:41:
> /usr/local/share/systemtap/runtime/transport/utt.c: In function ‘utt_dropped_open’:
> /usr/local/share/systemtap/runtime/transport/utt.c:199: error: ‘struct inode’ has no member named ‘u’
> In file included from /usr/local/share/systemtap/runtime/print.c:17,
>                  from /usr/local/share/systemtap/runtime/runtime.h:84,
>                  from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:41:
> /usr/local/share/systemtap/runtime/transport/transport.c: In function ‘_stp_transport_init’:
> /usr/local/share/systemtap/runtime/transport/transport.c:214: error: ‘struct task_struct’ has no member named ‘uid’
> /usr/local/share/systemtap/runtime/transport/transport.c:215: error: ‘struct task_struct’ has no member named ‘gid’
> In file included from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:42:
> /usr/local/share/systemtap/runtime/regs.c: In function ‘_stp_ret_addr’:
> /usr/local/share/systemtap/runtime/regs.c:49: error: ‘struct pt_regs’ has no member named ‘esp’
> /usr/local/share/systemtap/runtime/regs.c: In function ‘_stp_print_regs’:
> /usr/local/share/systemtap/runtime/regs.c:235: error: ‘struct pt_regs’ has no member named ‘eip’
> /usr/local/share/systemtap/runtime/regs.c:236: error: ‘struct pt_regs’ has no member named ‘esp’
> /usr/local/share/systemtap/runtime/regs.c:238: error: ‘struct pt_regs’ has no member named ‘eax’
> /usr/local/share/systemtap/runtime/regs.c:238: error: ‘struct pt_regs’ has no member named ‘ebx’
> /usr/local/share/systemtap/runtime/regs.c:238: error: ‘struct pt_regs’ has no member named ‘ecx’
> /usr/local/share/systemtap/runtime/regs.c:238: error: ‘struct pt_regs’ has no member named ‘edx’
> /usr/local/share/systemtap/runtime/regs.c:240: error: ‘struct pt_regs’ has no member named ‘esi’
> /usr/local/share/systemtap/runtime/regs.c:240: error: ‘struct pt_regs’ has no member named ‘edi’
> /usr/local/share/systemtap/runtime/regs.c:240: error: ‘struct pt_regs’ has no member named ‘ebp’
> /usr/local/share/systemtap/runtime/regs.c:242: error: ‘struct pt_regs’ has no member named ‘xds’
> /usr/local/share/systemtap/runtime/regs.c:242: error: ‘struct pt_regs’ has no member named ‘xes’
> /usr/local/share/systemtap/runtime/regs.c: In function ‘_stp_get_sp’:
> /usr/local/share/systemtap/runtime/regs.c:417: error: ‘struct pt_regs’ has no member named ‘esp’
> /usr/local/share/systemtap/runtime/regs.c:418: error: ‘struct pt_regs’ has no member named ‘esp’
> /usr/local/share/systemtap/runtime/regs.c: In function ‘_stp_get_arg32_by_number’:
> /usr/local/share/systemtap/runtime/regs.c:505: error: ‘struct pt_regs’ has no member named ‘eax’
> /usr/local/share/systemtap/runtime/regs.c:506: error: ‘struct pt_regs’ has no member named ‘edx’
> /usr/local/share/systemtap/runtime/regs.c:507: error: ‘struct pt_regs’ has no member named ‘ecx’
> In file included from /usr/local/share/systemtap/runtime/stack.c:35,
>                  from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:43:
> /usr/local/share/systemtap/runtime/stack-i386.c: In function ‘__stp_stack_print’:
> /usr/local/share/systemtap/runtime/stack-i386.c:33: error: ‘struct pt_regs’ has no member named ‘esp’
> /usr/local/share/systemtap/runtime/stack-i386.c:37: error: ‘struct pt_regs’ has no member named ‘ebp’
> In file included from /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c:43:
> /usr/local/share/systemtap/runtime/stack.c: In function ‘_stp_stack_print’:
> /usr/local/share/systemtap/runtime/stack.c:61: error: ‘struct pt_regs’ has no member named ‘eip’
> /usr/local/share/systemtap/runtime/stack.c:65: error: ‘struct pt_regs’ has no member named ‘eip’
> /usr/local/share/systemtap/runtime/stack.c:67: error: ‘struct pt_regs’ has no member named ‘eip’
> distcc[11858] ERROR: compile /tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.c on localhost failed
> make[1]: *** [/tmp/stapsXvMb1/stap_7e482897f22605cdad02e8e11f34d749_334.o] Error 1
> make: *** [_module_/tmp/stapsXvMb1] Error 2
> Pass 4: compiled C into "stap_7e482897f22605cdad02e8e11f34d749_334.ko" in 860usr/790sys/1733real ms.
> Pass 4: compilation failed.  Try again with another '--vp 0001' option.
> Running rm -rf /tmp/stapsXvMb1

Re: Latest systemtap fails when used with latest Linux kernel

[Frank Ch. Eigler]

"Theodore Ts'o" <tytso@mit.edu> writes:

> Using the latest Systemtap (commit be21f2db) compiling a 2.6.28-git7
> kernel, I get this failure....
> [...]

Something broke our runtime autoconf facility.  Investigating.

- FChE

Re: Latest systemtap fails when used with latest Linux kernel

[Masami Hiramatsu]

Hi Frank,

Frank Ch. Eigler wrote:
> "Theodore Ts'o" <tytso@mit.edu> writes:
> 
>> Using the latest Systemtap (commit be21f2db) compiling a 2.6.28-git7
>> kernel, I get this failure....
>> [...]
> 
> Something broke our runtime autoconf facility.  Investigating.

It seems that we need to add $(LINUXINCLUDE) to autoconf's CFLAGS.
(see 2.6.28/Makefile:332-334)

Thanks,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

Re: Latest systemtap fails when used with latest Linux kernel

[Masami Hiramatsu]

By the way, I've got below error on the latest -mm kernel(mmotm)
---
In file included from /usr/share/systemtap/runtime/transport/transport.c:22,
                 from /usr/share/systemtap/runtime/print.c:17,
                 from /usr/share/systemtap/runtime/runtime.h:84,
                 from /tmp/stapzZKUDf/stap_218dc83d664bf6a2b8f8f5c280eaff7f_176.c:41:
/usr/share/systemtap/runtime/transport/symbols.c:124:33: error: macro "swap" passed 3 arguments, but takes just 2
/usr/share/systemtap/runtime/transport/symbols.c:130:28: error: macro "swap" passed 3 arguments, but takes just 2
/usr/share/systemtap/runtime/transport/symbols.c:137:33: error: macro "swap" passed 3 arguments, but takes just 2
make[3]: *** [/tmp/stapzZKUDf/stap_218dc83d664bf6a2b8f8f5c280eaff7f_176.o] Error 1
make[2]: *** [_module_/tmp/stapzZKUDf] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
---

In runtime/transport/symbols.c, a function use a 'swap' function pointer,
however, below patch defined generic 'swap' macro in include/linux/kernel.h.

http://git.zen-sources.org/?p=mmotm.git;a=commit;h=ad1dae50a96703a7443df6335a27ec6112c194c8

So, I think we'd better change the variable name in advance. :-)

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

Re: Latest systemtap fails when used with latest Linux kernel

[Frank Ch. Eigler]

"Theodore Ts'o" <tytso@mit.edu> writes:

> Using the latest Systemtap (commit be21f2db) compiling a 2.6.28-git7
> kernel, I get this failure....
> [...]

Initial results (using an O=DIR x86_64 build) indicate that the kbuild
machinery was broken with respect to the include2/ symlink directory
in the build tree.  It was not updated when commit
bb8985586b7a906e116db835c64773b7a7d51663 moved a bunch of files from
include/asm/x86/ to arch/include/asm/.

- FChE

Re: Latest systemtap fails when used with latest Linux kernel

[David Smith]

Frank Ch. Eigler wrote:
> "Theodore Ts'o" <tytso@mit.edu> writes:
> 
>> Using the latest Systemtap (commit be21f2db) compiling a 2.6.28-git7
>> kernel, I get this failure....
>> [...]
> 
> Initial results (using an O=DIR x86_64 build) indicate that the kbuild
> machinery was broken with respect to the include2/ symlink directory
> in the build tree.  It was not updated when commit
> bb8985586b7a906e116db835c64773b7a7d51663 moved a bunch of files from
> include/asm/x86/ to arch/include/asm/.

I tested this on the latest rawhide kernel,
2.6.29-0.12.rc0.git7.fc11.x86_64.  I'm seeing 2 classes of problems:

1) autoconf problems - the autoconf tests are failing to find headers
included like "#include <linux/namei.h>".  (Here the problem *might* be
that the module sources are compiled with '-Iinclude' specified, but the
autoconf tests don't get compiled that way for some reason.)

To work around this one, you can specify the needed autoconfs on the
stap command line, like this:

# stap -DSTAPCONF_X86_UNIREGS -DSTAPCONF_INODE_PRIVATE
-DSTAPCONF_NAMEIDATA_CLEANUP -v -e 'probe begin { printf("hello\n") }'

(obviously this isn't even a short term solution, but it does kill lots
of compile errors)

2) with the -DSTAPCONF* added as above, then a real kernel change causes
us problems:

In file included from /usr/local/share/systemtap/runtime/print.c:17,
                 from /usr/local/share/systemtap/runtime/runtime.h:84,
                 from /tmp/stapnALnka/stap_30776.c:41:
/usr/local/share/systemtap/runtime/transport/transport.c: In function
‘_stp_transport_init’:
/usr/local/share/systemtap/runtime/transport/transport.c:214: error:
‘struct task_struct’ has no member named ‘uid’
/usr/local/share/systemtap/runtime/transport/transport.c:215: error:
‘struct task_struct’ has no member named ‘gid’

Handling this might entail adding another autoconf test looking for the
'cred' struct in task_struct (as mentioned by bug #9699).

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)