From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8307 invoked by alias); 6 Aug 2008 19:20:08 -0000 Received: (qmail 8298 invoked by uid 22791); 6 Aug 2008 19:20:07 -0000 X-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_20,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Aug 2008 19:19:33 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m76JJVLI029247; Wed, 6 Aug 2008 15:19:31 -0400 Received: from pobox-3.corp.redhat.com (pobox-3.corp.redhat.com [10.11.255.67]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m76JJUak009577; Wed, 6 Aug 2008 15:19:30 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.yyz.redhat.com [10.15.16.9]) by pobox-3.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m76JJ6bO009901; Wed, 6 Aug 2008 15:19:30 -0400 Received: from ton.toronto.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by touchme.toronto.redhat.com (Postfix) with ESMTP id AFA958001FF; Wed, 6 Aug 2008 15:18:49 -0400 (EDT) Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id m76JIX0v031050; Wed, 6 Aug 2008 15:18:33 -0400 Received: (from fche@localhost) by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id m76JIW1W031049; Wed, 6 Aug 2008 15:18:32 -0400 X-Authentication-Warning: ton.toronto.redhat.com: fche set sender to fche@redhat.com using -f To: Dave Nomura Cc: systemtap@sourceware.org Subject: Re: itrace patches References: <487F55BA.3090405@us.ibm.com> From: fche@redhat.com (Frank Ch. Eigler) Date: Wed, 06 Aug 2008 19:20:00 -0000 In-Reply-To: <487F55BA.3090405@us.ibm.com> (Dave Nomura's message of "Thu, 17 Jul 2008 07:22:50 -0700") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q3/txt/msg00363.txt.bz2 Dave Nomura writes: > Are the two patches that I submitted OK to commit? > [...] Thanks for committing. I'll move the test suite file to the appropriate place. While testing that though, I found a problem, so I'll initially disable the test. Can you elaborate upon the level of testing of this code? Has it been run under lockdep? On an RHEL5 x86-64 machine, I got: BUG: soft lockup - CPU#0 stuck for 10s! [ls_15964:16126] CPU 0: Modules linked in: stap_7c70ff0a5aa33e45a459d750475957f4_763(U) xt_tcpudp iptable_nat ip_nat ip_conntrack nfnet link ip_tables x_tables xfrm_nalgo crypto_api hidp l2cap bluetooth nfs lockd fscache nfs_acl sunrpc dm_multipat h video sbs backlight i2c_ec button battery asus_acpi acpi_memhotplug ac lp floppy ata_piix libata scsi_mod i2c _piix4 i2c_core pcspkr ide_cd 8139too parport_pc 8139cp mii parport serio_raw cdrom dm_snapshot dm_zero dm_mirr or dm_mod ext3 jbd uhci_hcd ohci_hcd ehci_hcd Pid: 16126, comm: ls_15964 Tainted: G 2.6.18-92.1.1.el5 #1 RIP: 0010:[] [] .text.lock.spinlock+0x2/0x30 RSP: 0018:ffff81001d279dd0 EFLAGS: 00000286 RAX: 0000000000003efe RBX: ffff8100104b2900 RCX: 0000000000000000 RDX: ffff8100104b2900 RSI: ffff8100188ee860 RDI: ffffffff883f64c0 RBP: ffffffff80061e22 R08: ffff81001d278000 R09: 0000000000000001 R10: ffff810016f059c8 R11: 0000000300000000 R12: 0000000000000282 R13: a3754e699d64d231 R14: ffff81000563c000 R15: 0000000000003efe FS: 0000000000000000(0000) GS:ffffffff8039f000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b CR2: 00007fff904eeaf9 CR3: 000000000dff2000 CR4: 00000000000006e0 Call Trace: [] :stap_7c70ff0a5aa33e45a459d750475957f4_763:usr_itrace_init+0x92/0x17d [] :stap_7c70ff0a5aa33e45a459d750475957f4_763:__stp_utrace_attach_match_tsk+0x17c/0x22e [] :stap_7c70ff0a5aa33e45a459d750475957f4_763:__stp_utrace_task_finder_report_exec+0x4d/0x4f [] utrace_report_exec+0x58/0x187 [] search_binary_handler+0x171/0x26d [] do_execve+0x18c/0x243 [] sys_execve+0x36/0x4c This could have been caused by create_itrace_info's use of an uninitialized spin_lock. It is not clear that a spinlock is appropriate at all, considering which of the protected calls could block. - FChE