From: fche@redhat.com (Frank Ch. Eigler)
To: Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com>
Cc: <systemtap@sourceware.org>
Subject: Re: [PATCH 1/3] add test cases for arith
Date: Tue, 08 Dec 2015 15:09:00 -0000 [thread overview]
Message-ID: <y0mio49yo2e.fsf@fche.csb> (raw)
In-Reply-To: <1449479119-10817-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> (Zhou Wenjian's message of "Mon, 7 Dec 2015 17:05:17 +0800")
Hi -
Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> writes:
> * testsuite/systemtap.base/arith.stp: add more cases
> [...]
I see nothing wrong with the proposed tests, but they seem to add very
little new coverage to the sorts of things thoroughly exercised
elsewhere. This set of arith.stp operator tests are probably OK, just
because we have their siblings there, but whitespace.stp IMHO doesn't
do anything special.
(By the way, there are also all kinds of other contributions worth
considering, be it documentation or bug or features fixes. We'd love
to mentor folks with any of these areas.)
- FChE
next prev parent reply other threads:[~2015-12-08 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 9:07 Zhou Wenjian
2015-12-07 9:07 ` [PATCH 3/3] add new case for white space Zhou Wenjian
2015-12-07 9:07 ` [PATCH 2/3] add more case for delete Zhou Wenjian
2015-12-08 15:09 ` Frank Ch. Eigler [this message]
2015-12-09 9:43 ` [PATCH 1/3] add test cases for arith "Zhou, Wenjian/周文剑"
2015-12-09 21:40 ` David Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y0mio49yo2e.fsf@fche.csb \
--to=fche@redhat.com \
--cc=systemtap@sourceware.org \
--cc=zhouwj-fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).