From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38519 invoked by alias); 8 Dec 2015 15:09:46 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 38509 invoked by uid 89); 8 Dec 2015 15:09:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_50,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 08 Dec 2015 15:09:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 8E86FC0B0204; Tue, 8 Dec 2015 15:09:42 +0000 (UTC) Received: from fche.csb (unused [10.10.52.179] (may be forged)) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB8F9gEL002408; Tue, 8 Dec 2015 10:09:42 -0500 Received: by fche.csb (Postfix, from userid 2569) id 5918B5851D; Tue, 8 Dec 2015 10:09:29 -0500 (EST) To: Zhou Wenjian Cc: Subject: Re: [PATCH 1/3] add test cases for arith References: <1449479119-10817-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> From: fche@redhat.com (Frank Ch. Eigler) Date: Tue, 08 Dec 2015 15:09:00 -0000 In-Reply-To: <1449479119-10817-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> (Zhou Wenjian's message of "Mon, 7 Dec 2015 17:05:17 +0800") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2015-q4/txt/msg00242.txt.bz2 Hi - Zhou Wenjian writes: > * testsuite/systemtap.base/arith.stp: add more cases > [...] I see nothing wrong with the proposed tests, but they seem to add very little new coverage to the sorts of things thoroughly exercised elsewhere. This set of arith.stp operator tests are probably OK, just because we have their siblings there, but whitespace.stp IMHO doesn't do anything special. (By the way, there are also all kinds of other contributions worth considering, be it documentation or bug or features fixes. We'd love to mentor folks with any of these areas.) - FChE