From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11421 invoked by alias); 12 Jul 2008 01:58:33 -0000 Received: (qmail 11204 invoked by uid 22791); 12 Jul 2008 01:58:33 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 12 Jul 2008 01:58:09 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m6C1w8DO019844; Fri, 11 Jul 2008 21:58:08 -0400 Received: from pobox-3.corp.redhat.com (pobox-3.corp.redhat.com [10.11.255.67]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m6C1w7kH022396; Fri, 11 Jul 2008 21:58:07 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.yyz.redhat.com [10.15.16.9]) by pobox-3.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m6C1vZXj015831; Fri, 11 Jul 2008 21:58:07 -0400 Received: from ton.toronto.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by touchme.toronto.redhat.com (Postfix) with ESMTP id C134F8001FF; Fri, 11 Jul 2008 21:57:18 -0400 (EDT) Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id m6C1v2kN031316; Fri, 11 Jul 2008 21:57:02 -0400 Received: (from fche@localhost) by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id m6C1v1Tb031315; Fri, 11 Jul 2008 21:57:01 -0400 X-Authentication-Warning: ton.toronto.redhat.com: fche set sender to fche@redhat.com using -f To: Anup C Shan Cc: systemtap@sources.redhat.com, kghoshnitk@gmail.com, akinobu.mita@gmail.com, k-tanaka@ce.jp.nec.com Subject: Re: [RFC 1/5] Kernel Fault injection framework using SystemTap References: <48773047.1050906@gmail.com> From: fche@redhat.com (Frank Ch. Eigler) Date: Sat, 12 Jul 2008 01:58:00 -0000 In-Reply-To: <48773047.1050906@gmail.com> (Anup C. Shan's message of "Fri, 11 Jul 2008 15:34:55 +0530") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q3/txt/msg00154.txt.bz2 Anup C Shan writes: > [...] We have designed a tapset for fault injection. It is meant to > ease the process of injecting faults into the kernel. As use cases, > we have ported in-kernel fault injection for slab and page_alloc > using this framework. Refer Documentation/fault-injection/ Neat. > Comments and suggestions are welcome. Please suggest a right > location to place these tapset scripts in SystemTap source tree. It seems like it's special-purpose enough to warrant a place in among the examples, which are currently checked in at .../testsuite/systemtap.examples/, as opposed to the tapset proper. The scripts and a README could go into a new subdirectory. For cataloging the scripts, a brief ".meta" file should accompany each end-user (as opposed to tapset) script. They could each have a "test_check" field to compile-test the scripts. (A test_installcheck field to actually inject faults into a running developer system is probably not appropriate. :-) Please place proper copyright notes and GPLv2+ license terms on the files; then we can package them. - FChE