From: fche@redhat.com (Frank Ch. Eigler)
To: Martin Hunt <hunt@redhat.com>
Cc: systemtap@sources.redhat.com
Subject: Re: how to handle userspace string copy failures
Date: Thu, 25 May 2006 19:22:00 -0000 [thread overview]
Message-ID: <y0mlkspucz3.fsf@ton.toronto.redhat.com> (raw)
In-Reply-To: <1148580663.6909.12.camel@dragon>
hunt wrote:
> [...] So, for the record, we cannot guarantee always being able to
> always access userspace
We need to investigate to what extent this problem can be worked
around by clever other ways. For example, can we arrange to
preemptively fault in more parts of programs when systemtap probes are
running?
> and such failures should not terminate the script.
See the MAXERRORS parameter.
> At worst, I think we should print warnings. I also propose that any
> user_string() request that fails should return "<unknown>".
I am uncomfortable with hard-coding such a decorated english term. A
simple blank string would be fine.
I would be happier if the decision for treatment as a soft vs. hard
error were left up to the caller script. One way to do this would be
to fork user_string() into two variants, one of which signals the
current sort of error-level fault (as does kernel_string()), and one
that just returns a sentinel soft-error value. Hey, that sentinel
value could even be passed to it as an additional argument.
- FChE
next prev parent reply other threads:[~2006-05-25 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 18:11 Martin Hunt
2006-05-25 19:22 ` Frank Ch. Eigler [this message]
2006-05-25 21:05 ` Martin Hunt
2006-05-25 21:20 ` Frank Ch. Eigler
2006-05-25 22:42 ` Tim Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y0mlkspucz3.fsf@ton.toronto.redhat.com \
--to=fche@redhat.com \
--cc=hunt@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).