public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* Changelog entries
@ 2006-02-06 14:17 William Cohen
  2006-02-06 16:14 ` Frank Ch. Eigler
  0 siblings, 1 reply; 2+ messages in thread
From: William Cohen @ 2006-02-06 14:17 UTC (permalink / raw)
  To: SystemTAP

When checking in changes for systemtap please list what files where 
changed in the ChangeLog. One should be able to look in the ChangeLog to 
find out what files have been added or modified. It looks like some 
enties have been omitted. There was a systematic failure of the nightly 
tests due changes in tapset/syscall2.stp on Friday. The problem was 
found looking the cvs changes, but it would have been a bit more obvious 
if there was an associated ChangeLog entry.

-Will

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Changelog entries
  2006-02-06 14:17 Changelog entries William Cohen
@ 2006-02-06 16:14 ` Frank Ch. Eigler
  0 siblings, 0 replies; 2+ messages in thread
From: Frank Ch. Eigler @ 2006-02-06 16:14 UTC (permalink / raw)
  To: systemtap


wcohen wrote:

> [...] There was a [systemic] failure of the nightly tests due
> changes in tapset/syscall2.stp on Friday. [...]

Beyond ChangeLog entries, think testing!  Before one commits a change,
one should run at least the simple regression test suite.  It would
have pointed out the subject syntax error immediately.  Please see
src/HACKING for more inspiration.

- FChE

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-02-06 16:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-06 14:17 Changelog entries William Cohen
2006-02-06 16:14 ` Frank Ch. Eigler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).