回复: Re: Change for aux_syscalls.stp

回复: Re: Change for aux_syscalls.stp

[WENJI.HUANG]

Frank,

   Sorry for my ambiguous expression.
   In fact, I found NFSCTL_UGIDUPDATE,NFSCTL_GETFH, NFSCTL_GETFD and NFSCTL_GETFS in kernel 2.4
   But NFSCTL_UGIDUPDATE and NFSCTL_GETFH are discarded in kernel >= 2.6.0

   Don't know why these changes happened(from Changelog). 
 
Regards,
Wenji
> 
> wenji.huang wrote:
> 
> >     Since 2.6.16, new SCHED_BATCH policy is added .
> >     Since 2.6
> > 
> >     NFSCTL_UGIDUPDATE and NFSCTL_GETFH are discarded.
> >     NFSCTL_GETFD and NFSCTL_GETFS are added.
> > [...]
> 
> I'm not sure how to read this.  Do UGIDUPDATE and GETFH never
> appear
> on any 2.6 kernel?  If so, it could be OK to remove them.  If
> those
> values are still used on some 2.6 kernels, I see no harm in
> keeping
> the number->name mappings around.
> 
> - FChE

Re: 回复: Re: Change for aux_syscalls.stp

[Frank Ch. Eigler]

WENJI.HUANG wrote:

>  In fact, I found NFSCTL_UGIDUPDATE,NFSCTL_GETFH, NFSCTL_GETFD and
>  NFSCTL_GETFS in kernel 2.4 But NFSCTL_UGIDUPDATE and NFSCTL_GETFH
>  are discarded in kernel >= 2.6.0

OK.  Given the absence of conflict between between all these enums, I
would prefer to leave the entry in the tapset.  This is especially
appropriate for data values that may come from old userspace, and
would otherwise fall through to anonymous "default:" branches.

- FChE