From: fche@redhat.com (Frank Ch. Eigler)
To: "Zhaolei" <zhaolei@cn.fujitsu.com>
Cc: <systemtap@sourceware.org>
Subject: Re: [patch] For memory access error when calling _stp_sockaddr_str with addrlen set to 0
Date: Wed, 05 Sep 2007 22:49:00 -0000 [thread overview]
Message-ID: <y0mps0xou4b.fsf@ton.toronto.redhat.com> (raw)
In-Reply-To: <00d501c7ef97$931426a0$85697c0a@guest004> (zhaolei@cn.fujitsu.com's message of "Wed, 5 Sep 2007 17:34:28 +0900")
"Zhaolei" <zhaolei@cn.fujitsu.com> writes:
> I found a memory access error in aux_syscall.stp's _stp_sockaddr_str
> function.
Thanks.
> [...] Also, I think the buf's length should be considered when
> using it. If no objection, I will commit the following patch:
Looks good, except that I suggest using sizeof()-based expressions
instead of literal numbers for the length comparisons, if possible.
- FChE
next prev parent reply other threads:[~2007-09-05 18:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1188780895.5736.ezmlm@sourceware.org>
2007-09-03 12:48 ` [patch] Modify flag's value in tapset's probe delete_module Zhaolei
2007-09-05 14:46 ` [patch] For memory access error when calling _stp_sockaddr_str with addrlen set to 0 Zhaolei
2007-09-05 22:49 ` Frank Ch. Eigler [this message]
2007-09-10 5:03 ` [patch] For getrusage's argstr in tapset Zhaolei
2007-09-10 5:21 ` Wenji Huang
2007-09-10 9:28 ` Zhaolei
2007-09-10 14:01 ` Wenji Huang
2007-09-13 16:06 ` Zhaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y0mps0xou4b.fsf@ton.toronto.redhat.com \
--to=fche@redhat.com \
--cc=systemtap@sourceware.org \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).