From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-7110-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 12720 invoked by alias); 5 Sep 2007 18:16:53 -0000
Received: (qmail 12443 invoked by uid 22791); 5 Sep 2007 18:16:52 -0000
X-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Sep 2007 18:16:46 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l85IGdQI010594; 	Wed, 5 Sep 2007 14:16:39 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l85IGcHG014314; 	Wed, 5 Sep 2007 14:16:38 -0400
Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) 	by pobox.toronto.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l85IGcMe019926; 	Wed, 5 Sep 2007 14:16:38 -0400
Received: from ton.toronto.redhat.com (ton.toronto.redhat.com [172.16.14.15]) 	by touchme.toronto.redhat.com (Postfix) with ESMTP 	id D652A80019E; Wed,  5 Sep 2007 14:16:37 -0400 (EDT)
Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) 	by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id l85IGbJD021529; 	Wed, 5 Sep 2007 14:16:37 -0400
Received: (from fche@localhost) 	by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id l85IGavT021527; 	Wed, 5 Sep 2007 14:16:36 -0400
X-Authentication-Warning: ton.toronto.redhat.com: fche set sender to fche@redhat.com using -f
To: "Zhaolei" <zhaolei@cn.fujitsu.com>
Cc: <systemtap@sourceware.org>
Subject: Re: [patch] For memory access error when calling _stp_sockaddr_str with addrlen set to 0
References: <1188780895.5736.ezmlm@sourceware.org> 	<006d01c7edd9$55a2b080$85697c0a@guest004> 	<00d501c7ef97$931426a0$85697c0a@guest004>
From: fche@redhat.com (Frank Ch. Eigler)
Date: Wed, 05 Sep 2007 22:49:00 -0000
In-Reply-To: <00d501c7ef97$931426a0$85697c0a@guest004> (zhaolei@cn.fujitsu.com's message of "Wed, 5 Sep 2007 17:34:28 +0900")
Message-ID: <y0mps0xou4b.fsf@ton.toronto.redhat.com>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2007-q3/txt/msg00516.txt.bz2

"Zhaolei" <zhaolei@cn.fujitsu.com> writes:

> I found a memory access error in aux_syscall.stp's _stp_sockaddr_str
> function.

Thanks.

> [...]  Also, I think the buf's length should be considered when
> using it.  If no objection, I will commit the following patch:

Looks good, except that I suggest using sizeof()-based expressions
instead of literal numbers for the length comparisons, if possible.


- FChE