public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: fche@redhat.com (Frank Ch. Eigler)
To: Perry Cheng <perryche@us.ibm.com>
Cc: "systemtap@sources.redhat.com" <systemtap@sources.redhat.com>
Subject: Re: Cannot access data passed in via gettimeofday
Date: Fri, 15 Dec 2006 21:08:00 -0000	[thread overview]
Message-ID: <y0mslfhjo33.fsf@ton.toronto.redhat.com> (raw)
In-Reply-To: <OF0D2461E2.660D946F-ON85257244.0078E70A-85257244.0079C9A5@us.ibm.com>


Perry Cheng <perryche@us.ibm.com> writes:

> [...]  I can't seem to see the data at all despite using the
> copy_from_user function to copy data from user to kernel space.
> [...]

Please be aware that might_sleep functions such as copy_from_user
should not generally be called from systemtap probe handlers.
Instead, one needs to use the atomic variants provided in the standard
tapset ... except we seem to lack a variant for copying over a struct
or an integer!  We have had one old bug to improve target expression
syntax so this would be automated (#2049, to allow e.g. $tv=>tv_sec).

All that doesn't explain though why you're getting odd results.  Does
the $tv pointer value itself seem plausible?  Kernel/gcc version?


- FChE

  parent reply	other threads:[~2006-12-15 13:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-14 23:20 Perry Cheng
2006-12-15  3:16 ` Eugene Teo
2006-12-15 21:08 ` Frank Ch. Eigler [this message]
     [not found] <OF326DF462.A6D86C8A-ON85257245.00099860-85257245.00099F31@mck.us.ray.com>
2006-12-15  3:45 ` Dave Sperry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y0mslfhjo33.fsf@ton.toronto.redhat.com \
    --to=fche@redhat.com \
    --cc=perryche@us.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).