From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29419 invoked by alias); 5 Feb 2009 14:55:32 -0000 Received: (qmail 29404 invoked by uid 22791); 5 Feb 2009 14:55:31 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Feb 2009 14:55:24 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n15EtLvs022268 for ; Thu, 5 Feb 2009 09:55:21 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n15EtN8p030510 for ; Thu, 5 Feb 2009 09:55:23 -0500 Received: from ton.toronto.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n15EtBUM029832; Thu, 5 Feb 2009 09:55:12 -0500 Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id n15EtABm024632; Thu, 5 Feb 2009 09:55:10 -0500 Received: (from fche@localhost) by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id n15EtADr024631; Thu, 5 Feb 2009 09:55:10 -0500 To: William Cohen Cc: SystemTAP Subject: Re: Return values for vm.pagefault.return changed with newer kernels References: <4989F643.8090204@redhat.com> From: fche@redhat.com (Frank Ch. Eigler) Date: Thu, 05 Feb 2009 16:56:00 -0000 In-Reply-To: <4989F643.8090204@redhat.com> (William Cohen's message of "Wed, 04 Feb 2009 15:10:43 -0500") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q1/txt/msg00357.txt.bz2 William Cohen writes: > [...] > Seems like the saner way to take care of this is to move the this information > into the tapsets/memory.stp [...] > > function vm_fault_minor(long:fault_no) > function vm_fault_major(long:fault_no) > function vm_fault_oom(long:fault_no) > function vm_fault_sigbus(long:fault_no) > function vm_fault_error(long:fault_no) I guess we need to speculate about future uses and possible future changes of this stuff. It would make about as much sense to have something smaller api-wise: a single test function function vm_fault_class_p(fault_number:long, class:string) and a variable that lists available classes global vm_fault_classes:string [] ... or else to have code that converts the old style enums to new style bit masks in some tapset variable. - FChE