public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: fche@redhat.com (Frank Ch. Eigler)
To: "Stone, Joshua I" <joshua.i.stone@intel.com>
Cc: <systemtap@sourceware.org>
Subject: Re: Tapset difficulties w/ functions
Date: Sun, 30 Apr 2006 20:05:00 -0000	[thread overview]
Message-ID: <y0mwtd6rfrr.fsf@ton.toronto.redhat.com> (raw)
In-Reply-To: <CBDB88BFD06F7F408399DBCF8776B3DC07128FD6@scsmsx403.amr.corp.intel.com>


joshua.i.stone wrote:

> [...]
> A very clean solution I came up with requires tapset wildcards that
> ignore "missing" matches.  We've discussed this before to make
> "syscall.*" easier, but that was decided against.  However, here's
> another example of how this could make things very clean:
> 
>   probe process.exec = _process.exec.* { /* do stuff */ }
>   probe _process.exec.part1 = kernel.function("do_execve") {}
>   probe _process.exec.part2 = kernel.function("compat_do_execve") {}
> [...]

Thank you (and Martin) for keeping on this.  Such data is just what
the argument needs to move forward.

> [...] Another problem I have is with a signal handling probe -
> handle_signal seems perfect for this, except that on the 2096_FC5
> kernel this function is inlined.  [...]  One solution is to have a
> new dwarf-probe that will match both normal functions and inlines.

This was being discussed in old bug #1570.  We didn't get that to a
conclusion.  (The .inline() vs .function() distinction was invented
for supporting .function("*),.function("*").return idioms.

Would this "fault-tolerant" wildcarding have an advantage over an
explicit "optional probe" syntax like this:

probe FOO ? { } 
probe alias = BAR ?, BAZ ? { }

Then the first alternative would be expressed thusly, if they can
share handlers:

probe process.exec = kernel.function("do_execve") ?,
                     kernel.function("compat_do_execve") ?
{ /* do stuff */ }


- FChE

  reply	other threads:[~2006-04-30 20:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-28 23:16 Stone, Joshua I
2006-04-30 20:05 ` Frank Ch. Eigler [this message]
2006-05-01 17:53 Stone, Joshua I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y0mwtd6rfrr.fsf@ton.toronto.redhat.com \
    --to=fche@redhat.com \
    --cc=joshua.i.stone@intel.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).