Warnings without -Wno-unused

Warnings without -Wno-unused

[Ananth N Mavinakayanahalli]

Hi,

I used Frank's syscall.open example from the systemtap tutorial,
used the -k option and wrote a custom makefile to build the module
later in the /tmp dir. Here is the output:

-----
[root@jataayu stapW5pqzA]# make
make -C /lib/modules/2.6.15-1.1833_FC4.root/build
SUBDIRS=/tmp/stapW5pqzA modules
make[1]: Entering directory
`/usr/src/kernels/2.6.15-1.1833_FC4.root-i686'
  CC [M]  /tmp/stapW5pqzA/stap_2958.o
/tmp/stapW5pqzA/stap_2958.c: In function ‘probe_0’:
/tmp/stapW5pqzA/stap_2958.c:1279: warning: label ‘unlock_’ defined but not used
/tmp/stapW5pqzA/stap_2958.c: In function ‘probe_1’:
/tmp/stapW5pqzA/stap_2958.c:1382: warning: label ‘unlock_’ defined but not used
/tmp/stapW5pqzA/stap_2958.c: In function ‘systemtap_module_init’:
/tmp/stapW5pqzA/stap_2958.c:1480: warning: unused variable ‘probe_point’
/tmp/stapW5pqzA/stap_2958.c: At top level:
/usr/local/share/systemtap/runtime/transport/transport.c:26: warning: ‘_stp_dpid’ defined but not used
/usr/local/share/systemtap/runtime/transport/transport.c:51: warning: ‘_stp_streaming’ defined but not used
/usr/local/share/systemtap/runtime/io.c:161: warning: ‘_stp_dbug’ defined but not used
/usr/local/share/systemtap/runtime/print.c:160: warning: ‘next_fmt’ defined but
not used
  Building modules, stage 2.
  MODPOST
  CC      /tmp/stapW5pqzA/stap_2958.mod.o
  LD [M]  /tmp/stapW5pqzA/stap_2958.ko
  make[1]: Leaving directory
  `/usr/src/kernels/2.6.15-1.1833_FC4.root-i686'
-----

As you see, the warnings are benign (currently) and are supressed 'cos of
-Wno-unused in the Makefile generated by stap. But we should revisit this
issue sometime (sooner rather than later) and fixup wherever possible.

Do we already have a bugzilla for this? If not, should one be opened?

Ananth

Re: Warnings without -Wno-unused

[Frank Ch. Eigler]

ananth wrote:

> [without -Wno-unused ...]

I agree that we should not need that flag.

> /tmp/stapW5pqzA/stap_2958.c:1279: warning: label unlock_ defined but not used
> /tmp/stapW5pqzA/stap_2958.c:1382: warning: label unlock_ defined but not used
> /tmp/stapW5pqzA/stap_2958.c:1480: warning: unused variable probe_point

I will fix these.

Martin will need to fix these.  They look familiar: I suspect he added
the "-Wno-unused" flag to buildrun.cxx back last summer precisely
because he didn't like my hack in the translator to emit dummy
references to these symbols.

> /usr/local/share/systemtap/runtime/transport/transport.c:26: warning: _stp_dpid defined but not used
> /usr/local/share/systemtap/runtime/transport/transport.c:51: warning: _stp_streaming defined but not used
> /usr/local/share/systemtap/runtime/io.c:161: warning: _stp_dbug defined but not used
> /usr/local/share/systemtap/runtime/print.c:160: warning: next_fmt defined but

- FChE