From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24973 invoked by alias); 9 Mar 2006 14:09:24 -0000 Received: (qmail 24965 invoked by uid 22791); 9 Mar 2006 14:09:24 -0000 X-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 09 Mar 2006 14:09:21 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k29E9Juo015644 for ; Thu, 9 Mar 2006 09:09:19 -0500 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k29E9J115076; Thu, 9 Mar 2006 09:09:19 -0500 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id k29E9IXN021399; Thu, 9 Mar 2006 09:09:18 -0500 Received: from ton.toronto.redhat.com (ton.toronto.redhat.com [172.16.14.15]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 914E08001FF; Thu, 9 Mar 2006 09:09:18 -0500 (EST) Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id k29E9I6S001667; Thu, 9 Mar 2006 09:09:18 -0500 Received: (from fche@localhost) by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id k29E9Hvt001664; Thu, 9 Mar 2006 09:09:17 -0500 X-Authentication-Warning: ton.toronto.redhat.com: fche set sender to fche@redhat.com using -f To: ananth@in.ibm.com Cc: systemtap@sources.redhat.com Subject: Re: Warnings without -Wno-unused References: <20060308102702.GA8502@in.ibm.com> From: fche@redhat.com (Frank Ch. Eigler) Date: Thu, 09 Mar 2006 14:09:00 -0000 In-Reply-To: <20060308102702.GA8502@in.ibm.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00744.txt.bz2 ananth wrote: > [without -Wno-unused ...] I agree that we should not need that flag. > /tmp/stapW5pqzA/stap_2958.c:1279: warning: label unlock_ defined but not used > /tmp/stapW5pqzA/stap_2958.c:1382: warning: label unlock_ defined but not used > /tmp/stapW5pqzA/stap_2958.c:1480: warning: unused variable probe_point I will fix these. Martin will need to fix these. They look familiar: I suspect he added the "-Wno-unused" flag to buildrun.cxx back last summer precisely because he didn't like my hack in the translator to emit dummy references to these symbols. > /usr/local/share/systemtap/runtime/transport/transport.c:26: warning: _stp_dpid defined but not used > /usr/local/share/systemtap/runtime/transport/transport.c:51: warning: _stp_streaming defined but not used > /usr/local/share/systemtap/runtime/io.c:161: warning: _stp_dbug defined but not used > /usr/local/share/systemtap/runtime/print.c:160: warning: next_fmt defined but - FChE