* Xconq bug fixes + binaries @ 2003-10-19 11:09 Hans Ronne 2003-10-19 13:15 ` Peter Garrone 0 siblings, 1 reply; 7+ messages in thread From: Hans Ronne @ 2003-10-19 11:09 UTC (permalink / raw) To: xconq7 I have cheked in a large number of kernel bug fixes, mostly in the material handling code. For details, see the ChangeLog. Peter Garrone's material capacity display code has also been added to the tcltk interface. Several bugs have been fixed in the Windows interface as well. The advanced graphics (terrain transitions etc.) now works again on Windows XP. It was accidentally disabled on all Windows version in the last binaries, not only on pre-NT versions, as intended. A terrain drawing bug that sneaked in recently has also been fixed. Some problems with checkpoint files and Finder labels have been fixed in the Mac interface. New binaries for all platforms are available at: http://w1.694.comhem.se/~u69400018/ Hans ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Xconq bug fixes + binaries 2003-10-19 11:09 Xconq bug fixes + binaries Hans Ronne @ 2003-10-19 13:15 ` Peter Garrone 2003-10-19 15:39 ` Hans Ronne 0 siblings, 1 reply; 7+ messages in thread From: Peter Garrone @ 2003-10-19 13:15 UTC (permalink / raw) To: xconq7 On Sat, Oct 18, 2003 at 09:05:02PM +0200, Hans Ronne wrote: > I have cheked in a large number of kernel bug fixes, mostly in the material > handling code. For details, see the ChangeLog. Peter Garrone's material > capacity display code has also been added to the tcltk interface. Before application, some "improvements" were made to my code, without my consultation, but attributing the results to me. I cannot take any responsibility for the results. I am sure it is well meant. But this is the second time that this has occurred, and it is annoying. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Xconq bug fixes + binaries 2003-10-19 13:15 ` Peter Garrone @ 2003-10-19 15:39 ` Hans Ronne 2003-10-19 19:20 ` Jim Kingdon 0 siblings, 1 reply; 7+ messages in thread From: Hans Ronne @ 2003-10-19 15:39 UTC (permalink / raw) To: Peter Garrone; +Cc: xconq7 >On Sat, Oct 18, 2003 at 09:05:02PM +0200, Hans Ronne wrote: >> I have cheked in a large number of kernel bug fixes, mostly in the material >> handling code. For details, see the ChangeLog. Peter Garrone's material >> capacity display code has also been added to the tcltk interface. > > Before application, some "improvements" were made to my code, > without my consultation, but attributing the results to me. > > I cannot take any responsibility for the results. > > I am sure it is well meant. But this is the second time that this has > occurred, and it is annoying. There were a number of problems with your first submitted code, such as incorrect handling advanced units, no support for side treasuries, and a failure to update the material display beyond turn 1. I took the trouble to fix these bugs and also added some features, such as the display of material icons in the list, since we need more Xconq hackers and I thought your contribution was useful. A bug affecting production values did sneak in when I added support for advanced units (as you noted) but it has now been fixed. As for your second patch, I already explained twice why "infinite" capacities do not exist and why your code had to be changed in that respect. Other changes were prompted by changes in the treasury code, which I checked in at the same time. There were also some other fixes. For example, I substituted a call to base_production instead of the raw um_base_production value since it handles the production of occupants correctly. Finally, the code was edited to conform with the Xconq coding standards (as set by Stan). If some parts of the code avoid using brackets and some parts always use them, the code becomes difficult to read. I encourage you to submit more patches, since you are a talented coder with some new ideas for how to improve Xconq. However, you will have to accept that patches are checked and bugs are fixed before inclusion, particularly this close to a release. It is also important that new features work as expected with all game modules, not just with one or two of them. Hans ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Xconq bug fixes + binaries 2003-10-19 15:39 ` Hans Ronne @ 2003-10-19 19:20 ` Jim Kingdon 2003-10-20 12:11 ` Hans Ronne 0 siblings, 1 reply; 7+ messages in thread From: Jim Kingdon @ 2003-10-19 19:20 UTC (permalink / raw) To: hronne; +Cc: pgarrone, xconq7 > However, you will have to accept that patches are checked and bugs are > fixed before inclusion Hopefully it is understood by all that any submission will get modified (if not immediately, then eventually as xconq evolves). There is one legitimate complaint here, though, and that is how it is described in the ChangeLog. I've added the word "(modified)" to make it clear that what was checked in contains work from both Peter Garonne and Hans Ronne. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Xconq bug fixes + binaries 2003-10-19 19:20 ` Jim Kingdon @ 2003-10-20 12:11 ` Hans Ronne 2003-10-20 16:49 ` Peter Garrone 0 siblings, 1 reply; 7+ messages in thread From: Hans Ronne @ 2003-10-20 12:11 UTC (permalink / raw) To: Jim Kingdon; +Cc: xconq7 >Hopefully it is understood by all that any submission will get >modified (if not immediately, then eventually as xconq evolves). Indeed. There is code in xconq I once wrote that I hardly recognize any more :-). >There is one legitimate complaint here, though, and that is how it is >described in the ChangeLog. I've added the word "(modified)" to make >it clear that what was checked in contains work from both Peter >Garonne and Hans Ronne. Right. I did add (modified) in the first checkin but not in the second one. The entry instead mentions some of the stuff I added explicitly (support for font preferences in the materials list) but not the other changes. Hans ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Xconq bug fixes + binaries 2003-10-20 12:11 ` Hans Ronne @ 2003-10-20 16:49 ` Peter Garrone 2003-10-26 4:32 ` Hans Ronne 0 siblings, 1 reply; 7+ messages in thread From: Peter Garrone @ 2003-10-20 16:49 UTC (permalink / raw) To: xconq7; +Cc: Hans Ronne On Sun, Oct 19, 2003 at 09:19:57PM +0200, Hans Ronne wrote: > >Hopefully it is understood by all that any submission will get > >modified (if not immediately, then eventually as xconq evolves). > > Indeed. There is code in xconq I once wrote that I hardly recognize any > more :-). > > >There is one legitimate complaint here, though, and that is how it is > >described in the ChangeLog. I've added the word "(modified)" to make > >it clear that what was checked in contains work from both Peter > >Garonne and Hans Ronne. > > Right. I did add (modified) in the first checkin but not in the second one. > The entry instead mentions some of the stuff I added explicitly (support > for font preferences in the materials list) but not the other changes. > > Hans Look I apologise. I was regarding the CVS checkin as the official release instead of as the point of collaboration. Sorry for alarming everyone, Hans in particular. I'm not worried about the changelog. Thanks very much for the attributions made, and I will also acknowledge that I believe my code has been improved especially by Hans. Just as long as it is understood that when something loosely based on my work is put into CVS, and attributed to me, it is not necessarily precisely as I envisaged it. Sincerely, Peter ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Xconq bug fixes + binaries 2003-10-20 16:49 ` Peter Garrone @ 2003-10-26 4:32 ` Hans Ronne 0 siblings, 0 replies; 7+ messages in thread From: Hans Ronne @ 2003-10-26 4:32 UTC (permalink / raw) To: Peter Garrone; +Cc: xconq7 >Look I apologise. I was regarding the CVS checkin as the official release >instead of as the point of collaboration. Sorry for alarming everyone, >Hans in particular. No offense taken. As I said, we need good coders with fresh ideas on this project. Hans ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2003-10-20 16:49 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2003-10-19 11:09 Xconq bug fixes + binaries Hans Ronne 2003-10-19 13:15 ` Peter Garrone 2003-10-19 15:39 ` Hans Ronne 2003-10-19 19:20 ` Jim Kingdon 2003-10-20 12:11 ` Hans Ronne 2003-10-20 16:49 ` Peter Garrone 2003-10-26 4:32 ` Hans Ronne
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).