public inbox for xconq7@sourceware.org
 help / color / mirror / Atom feed
From: Eric McDonald <mcdonald@phy.cmich.edu>
To: mskala@ansuz.sooke.bc.ca
Cc: xconq7@sources.redhat.com,  xconq-hackers@lists.sourceforge.net
Subject: Re: Thoughts on terrain imaging
Date: Wed, 24 Nov 2004 04:25:00 -0000	[thread overview]
Message-ID: <41A3FEF7.8000204@phy.cmich.edu> (raw)
In-Reply-To: <Pine.LNX.4.21.0411231648280.16026-100000@diamond.ansuz.sooke.bc.ca>

mskala@ansuz.sooke.bc.ca wrote:

> That image-rescaling code (which I've looked at a little more since
> writing my last message here) seems to be a real dog's breakfast.  There
> are a couple of points where it seems to be testing for error conditions
> in the very next line after that code that guarantees that the error
> condition can't happen, and there are other points where a comment
> explaining what's about do be done is followed by a line of code that
> clearly does something else.  I think those are signs it's been tweaked
> and patched several times in the past, and it may be that the best thing
> to do might be to simply rewrite those routines - not a project I had
> contemplated as part of the map-image feature addition, but one I'm
> willing to tackle if it turns out to be necessary.

Yes, parts of that code seemed a bit gnarled, __the few exposures that 
I've had to it. One of the reasons that I've been content to avoid it in 
the past....

I appreciate the fact that you are being open-minded about what sorts of 
  preparatory work may need to be done before getting down to "just 
writing the damned feature". I think that that is a healthy attitude to 
have when dealing with the Xconq sources.

   Best regards,
     Eric

  reply	other threads:[~2004-11-24  3:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-23 16:44 mskala
2004-11-23 22:08 ` Eric McDonald
2004-11-24  3:18   ` mskala
2004-11-24  4:25     ` Eric McDonald [this message]
2004-11-24 13:00 ` Eric McDonald
2004-11-25  2:50   ` mskala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41A3FEF7.8000204@phy.cmich.edu \
    --to=mcdonald@phy.cmich.edu \
    --cc=mskala@ansuz.sooke.bc.ca \
    --cc=xconq-hackers@lists.sourceforge.net \
    --cc=xconq7@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).