From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7240 invoked by alias); 25 Nov 2004 07:07:02 -0000 Mailing-List: contact xconq7-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: xconq7-owner@sources.redhat.com Received: (qmail 7127 invoked from network); 25 Nov 2004 07:06:57 -0000 Received: from unknown (HELO rwcrmhc12.comcast.net) (216.148.227.85) by sourceware.org with SMTP; 25 Nov 2004 07:06:57 -0000 Received: from [192.168.181.128] (c-67-176-41-158.client.comcast.net[67.176.41.158]) by comcast.net (rwcrmhc12) with ESMTP id <2004112507065601400re7n3e>; Thu, 25 Nov 2004 07:06:57 +0000 Message-ID: <41A58473.6080903@phy.cmich.edu> Date: Sat, 27 Nov 2004 00:33:00 -0000 From: Eric McDonald User-Agent: Mozilla Thunderbird 0.8 (Windows/20040913) MIME-Version: 1.0 To: mskala@ansuz.sooke.bc.ca CC: xconq7@sources.redhat.com, xconq-hackers@lists.sourceforge.net Subject: Re: Fix for "auto-generated images appear as black" bug References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004/txt/msg01439.txt.bz2 Hi Matthew, mskala@ansuz.sooke.bc.ca wrote: > Anyway, there are a few lines that have to be re-arranged to fix it, and > this patch does that. Other bugs are made more visible by this patch (in > particular, the "choose one subimage at random" code doesn't work with > shrunken or magnified images), and *really* shrunken images (like, down to > a single pixel as used at very low magnificatons) don't happen because of > hardcoded limits elsewhere, but at least it's an improvement. Yes, it is definitely an improvement. Patch read, understood, applied, tested, and committed. Thanks, Eric