From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23436 invoked by alias); 23 Nov 2004 22:08:26 -0000 Mailing-List: contact xconq7-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: xconq7-owner@sources.redhat.com Received: (qmail 23413 invoked from network); 23 Nov 2004 22:08:20 -0000 Received: from unknown (HELO urk.execulink.net) (199.166.6.45) by sourceware.org with SMTP; 23 Nov 2004 22:08:20 -0000 Received: from diamond.ansuz.sooke.bc.ca (ppp77.ac3.56k.execulink.com [209.239.3.77]) by urk.execulink.net (8.11.6/8.11.6) with ESMTP id iANM8Gf22364; Tue, 23 Nov 2004 17:08:16 -0500 Received: from localhost (mskala@localhost) by diamond.ansuz.sooke.bc.ca (8.10.2/8.10.2) with ESMTP id iANLsnI16218; Tue, 23 Nov 2004 16:54:49 -0500 Date: Wed, 24 Nov 2004 03:18:00 -0000 From: mskala@ansuz.sooke.bc.ca To: Eric McDonald cc: xconq7@sources.redhat.com, xconq-hackers@lists.sourceforge.net Subject: Re: Thoughts on terrain imaging In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2004/txt/msg01433.txt.bz2 On Tue, 23 Nov 2004, Eric McDonald wrote: > user account so that you can be added to the project as a > developer. I figure this might be easier than you submitting a > bunch of patches which people would have to apply if they wanted > to test out your work. Okay - I'll sign up for one. > For the per-cell case, you may want to implement new layers. I > believe that the 'aref' and 'aset' macros in 'world.h', IIRC, > would be worth looking at. (Layer allocation is handled elsewhere.) Yes - that's one of the things I'm looking at. > Regarding the bug reports: if you're offering to fix the bugs, > then that's great. If you would like some help fixing them, please > add them to the project's bug tracking system on Sourceforge, and > I will try to help you clear out some of them. I'd like to spend a little more time trying to figure out what's going on with these before I decide whether I can fix them easily myself, or want to file them for other people to look at; I was just commenting about them on the list in the hope that maybe you (or some other reader) would instantly recognize either the bug or the mistake I'm making in the GDL to cause the incorrect behaviour. That image-rescaling code (which I've looked at a little more since writing my last message here) seems to be a real dog's breakfast. There are a couple of points where it seems to be testing for error conditions in the very next line after that code that guarantees that the error condition can't happen, and there are other points where a comment explaining what's about do be done is followed by a line of code that clearly does something else. I think those are signs it's been tweaked and patched several times in the past, and it may be that the best thing to do might be to simply rewrite those routines - not a project I had contemplated as part of the map-image feature addition, but one I'm willing to tackle if it turns out to be necessary. -- Matthew Skala mskala@ansuz.sooke.bc.ca Embrace and defend. http://ansuz.sooke.bc.ca/