From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31592 invoked by alias); 17 Aug 2004 22:15:49 -0000 Mailing-List: contact xconq7-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: xconq7-owner@sources.redhat.com Received: (qmail 31522 invoked from network); 17 Aug 2004 22:15:44 -0000 Received: from unknown (HELO ob2.cmich.edu) (141.209.20.21) by sourceware.org with SMTP; 17 Aug 2004 22:15:44 -0000 Received: from egate1.central.cmich.local ([141.209.15.85]) by ob2.cmich.edu (8.12.10/8.12.10) with ESMTP id i7HMAbP6021209; Tue, 17 Aug 2004 18:10:37 -0400 Received: from leon.phy.cmich.edu ([141.209.165.20]) by egate1.central.cmich.local with Microsoft SMTPSVC(5.0.2195.6713); Tue, 17 Aug 2004 18:15:41 -0400 Received: from localhost (localhost [127.0.0.1]) by leon.phy.cmich.edu (Postfix) with ESMTP id 5F8E470011; Tue, 17 Aug 2004 18:15:38 -0400 (EDT) Date: Tue, 17 Aug 2004 22:59:00 -0000 From: Eric McDonald To: Hans Ronne Cc: xconq7@sources.redhat.com Subject: Re: The selective fire-at command In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 17 Aug 2004 22:15:41.0596 (UTC) FILETIME=[BBA7D5C0:01C484A7] X-CanItPRO-Stream: default X-Spam-Score: -0.9 () X-Bayes-Prob: 0.0001 X-Scanned-By: CanIt (www . canit . ca) X-SW-Source: 2004/txt/msg00938.txt.bz2 On Tue, 17 Aug 2004, Hans Ronne wrote: > You will notice that the pixel coordinates are converted to (x, y) by > nearest_cell, and these cell coordinates are then passed on to > common_fire_at. What this means is that all information about what unit > within the cell you were trying to target is lost. Right, and that caused problems later on when one needed more information in the 'common_fire_at' routine. > if (unit->side != side_n(uview->siden)) { > other = uview->unit; > /* Assume we have the right target. (Bad assumption, > but what else can one do with the info presently available?) */ I think the comment says it all. The function did what it could with the info available. > Now, two comments. First, the fire-at command does work in the Mac > interface since the pixel coordinates are passed on and the unit under the > cursor is identified. I think that when I was working on the Dec 29 fix, I wanted to fix this as well, but wasn't sure how to go about it because I didn't know the Tcl/Tk interface code all that well. In retrospect, I should have looked at the attack code for guidance. Eric