From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12091 invoked by alias); 5 Jul 2003 00:36:01 -0000 Mailing-List: contact xconq7-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: xconq7-owner@sources.redhat.com Received: (qmail 12084 invoked from network); 5 Jul 2003 00:36:01 -0000 Received: from unknown (HELO smtp2.fre.skanova.net) (195.67.227.95) by sources.redhat.com with SMTP; 5 Jul 2003 00:36:01 -0000 Received: from [212.181.162.155] (h155n1fls20o913.bredband.comhem.se [212.181.162.155]) by smtp2.fre.skanova.net (8.12.9/8.12.9) with ESMTP id h650ZrwZ026031; Sat, 5 Jul 2003 02:35:56 +0200 (CEST) X-Sender: u22611592@m1.226.telia.com Message-Id: In-Reply-To: <20030704232155.GA9945@low-shang.homelinux.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Sat, 05 Jul 2003 04:39:00 -0000 To: tlow@low-shang.homelinux.com (Tom Lowshang) From: Hans Ronne Subject: Re: emblem drawing glitches on linux Cc: xconq7@sources.redhat.com X-SW-Source: 2003/txt/msg00302.txt.bz2 >The glitches were introduced by the checkin on 2003-05-01, which >is mostly to do with unit views. This checkin still covers a lot >of code though, so is there anything I can do to narrow it down >further? Thanks, that was very useful information. Unfortunately, the new unit view code was a major change all over the kernel and the interfaces, so it is difficult to take it apart. However, for technical reasons I doubt that the problem is with the unit view code itself. Rather, I suspect some other changes thst were made at the same time. Two things come to mind: 1. There was a change in update_cell (end of tkmap.c) where an "erasing row" now always is drawn if we see unit views instead of units and unit names are shown on the map. What happens if you turn off unit names? Do you still see the glitches? And what happens if you start the game with see-all? Do they disappear then? 2. There weer also some changes to draw_current which draws the current unit. What happens if you back out of these changes (if possible) so that the unit view-specific code is bypassed? One way to achieve thtis is to change line 3246 in tkmap.c from: if (vp->show_all) { to: if (1) { Hans