public inbox for xconq7@sourceware.org
 help / color / mirror / Atom feed
From: Hans Ronne <hronne@comhem.se>
To: xconq7@sources.redhat.com
Subject: Major bug - progress report
Date: Tue, 17 Aug 2004 19:29:00 -0000	[thread overview]
Message-ID: <l03130301bd480274a4ad@[212.181.162.155]> (raw)

>1. Getting rid of unit pointers in the task code. I have looked into the
>possibility of feeding unit views instead of units to the attack and
>fire-at actions, as suggested by Stan, and I think it can be done. Most of
>the problems are related to interface callbacks that ask for real units,
>but I think they can be fixed with a reasonable amount of work.

This was a rather optimistic statement. In fact, the unit pointers go all
the way up to the interface code (via advance_into_cell). I'm purging the
tcltk interface of them right now, and had to add a bunch of x_unit_view_
functions in the process. I haven't even started with the other interfaces.

There are also cases where action code that already is dealing with real
units calls do_fire_at_action. Not sure what to do about that yet. Perhaps
clone the function.

So this may take a while, and will probably affect every kernel and
interface file in the end. But I think it had to be done. And it is only
now, when we have the improved, more unit-like unit views that it could
have been done.

Hans


                 reply	other threads:[~2004-08-17 18:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='l03130301bd480274a4ad@[212.181.162.155]' \
    --to=hronne@comhem.se \
    --cc=xconq7@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).