From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3187 invoked by alias); 5 Jun 2004 08:22:52 -0000 Mailing-List: contact xconq7-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: xconq7-owner@sources.redhat.com Received: (qmail 3172 invoked from network); 5 Jun 2004 08:22:44 -0000 Received: from unknown (HELO av13-1-sn4.m-sp.skanova.net) (81.228.10.104) by sourceware.org with SMTP; 5 Jun 2004 08:22:44 -0000 Received: by av13-1-sn4.m-sp.skanova.net (Postfix, from userid 502) id A0B6337E50; Sat, 5 Jun 2004 10:22:43 +0200 (CEST) Received: from smtp4-1-sn4.m-sp.skanova.net (smtp4-1-sn4.m-sp.skanova.net [81.228.10.181]) by av13-1-sn4.m-sp.skanova.net (Postfix) with ESMTP id 8EAC537E4B; Sat, 5 Jun 2004 10:22:43 +0200 (CEST) Received: from [212.181.162.155] (h155n1fls24o1048.bredband.comhem.se [212.181.162.155]) by smtp4-1-sn4.m-sp.skanova.net (Postfix) with ESMTP id 4401A37E42; Sat, 5 Jun 2004 10:22:42 +0200 (CEST) X-Sender: u22611592@m1.226.comhem.se Message-Id: In-Reply-To: References: <1086409175.1485.54.camel@localhost.localdomain> <20040605033742.12312.qmail@web13123.mail.yahoo.com> <20040605033742.12312.qmail@web13123.mail.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Sat, 05 Jun 2004 08:22:00 -0000 To: Eric McDonald From: Hans Ronne Subject: Re: Consumption-per-fire? Cc: xconq7@sources.redhat.com X-SW-Source: 2004/txt/msg00473.txt.bz2 >P.S. As a final note, some of the problems with consumption-per-fire are >due to the fact that you can use the fire-into action to fire at invisible >units. To avoid leaking info about unseen units back to the attacker, >check_fire_into_action therefore calls enough_ammo_to_fire_one_round which >does some kind of general check for ability to fire. However, I'm not sure >that this code, which bypasses the use of the hit-by table, works as >expected in all cases. As a followup, the reason why I don't like this code is that do_fire_into_action iterates over the stack and than uses a real test for each unit (enough_ammo_to_fire_at_unit) instead of the bogus test (enough_ammo_to_fire_one_round). It's not a good idea to have the check_action and do_action code use different tests. Hans