public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com>
To: "Zack Weinberg" <zack@owlfolio.org>
Cc: fweimer@redhat.com, libc-alpha@sourceware.org, toolybird@tuta.io
Subject: Re: [PATCH] malloc: Enable merging of remainders in memalign (bug 30723)
Date: Wed, 09 Aug 2023 19:10:43 -0400	[thread overview]
Message-ID: <xn7cq3q0b0.fsf@greed.delorie.com> (raw)
In-Reply-To: <04c5dca3-4e3c-4e46-a13f-e402637c15f3@app.fastmail.com> (zack@owlfolio.org)

"Zack Weinberg" <zack@owlfolio.org> writes:
> but could we have a more aggressive consolidation pass, capable of
> pulling stuff back out of the fastbins, that was triggered at least
> some fraction of the times we think we need to expand the heap?

Yes, except:

1. We don't currently keep track of the status of fastbins (how many
   chunks, now much memory) to have as a metric, and

2. We don't have a good bit of logic to decide which API call will be
   interrupted to do the consolidation.

In this day and age, I'd suggest a separate consolidation thread, but
that would mean we'd have to review our atomics etc and make sure there
weren't any unneeded delays or locks.


      reply	other threads:[~2023-08-09 23:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 18:51 Florian Weimer
2023-08-09 21:58 ` DJ Delorie
2023-08-09 22:20   ` Zack Weinberg
2023-08-09 23:10     ` DJ Delorie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xn7cq3q0b0.fsf@greed.delorie.com \
    --to=dj@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=toolybird@tuta.io \
    --cc=zack@owlfolio.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).